Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MONO ifdef from Vector128 bitcasts #104694

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove MONO ifdef from Vector128 bitcasts #104694

wants to merge 2 commits into from
+6 −52

Conversation

xtqqczze
Copy link
Contributor

Follow-up to #104309.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 10, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@tannergooding
Copy link
Member

We should wait on this until after we ensure it doesn't need to be backed out for Mono WASM: dotnet/perf-autofiling-issues#37893

Just trying to confirm the handling that needs to be added

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 10, 2024 •
edited
Loading

Depends on #104698.

@xtqqczze xtqqczze marked this pull request as draft July 10, 2024 23:21
This was referenced Jul 11, 2024
Open
Closed
Open
Closed
Closed
@xtqqczze xtqqczze marked this pull request as ready for review July 12, 2024 15:13
@xtqqczze xtqqczze force-pushed the Vector128BitCast branch 2 times, most recently from c97964a to 8d0e1f7 Compare July 16, 2024 20:42
@build-analysis build-analysis bot mentioned this pull request Jul 17, 2024
Closed
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 17, 2024 •
edited
Loading

Depends on #105009.

@xtqqczze xtqqczze marked this pull request as draft July 17, 2024 15:55
@xtqqczze xtqqczze marked this pull request as ready for review July 17, 2024 22:14
This was referenced Jul 18, 2024
Open
Closed
This was referenced Oct 22, 2024
Open
Open
Open
Closed
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 29, 2024 •
edited
Loading 

08:09:10.594 Running test: _Vector128_1_r::JIT.HardwareIntrinsics.General._Vector128_1.Program.AsVector4Single()
Beginning scenario: RunBasicScenario
Beginning scenario: RunReflectionScenario
* Assertion at D:\a\_work\1\s\src\mono\mono\mini\method-to-ir.c:13613, condition `var->opcode == OP_REGOFFSET' not met

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-104694-merge-21b422aec23d4be0ac/HardwareIntrinsics_General_r/1/console.8b18dec4.log?helixlogtype=result

@tannergooding
Copy link
Member

You'll need to log an issue for it and wait for the Mono side to be fixed before this PR can be taken.

@xtqqczze xtqqczze mentioned this pull request Oct 29, 2024
Open
@xtqqczze xtqqczze marked this pull request as draft October 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xtqqczze @tannergooding