-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DebuggerDisableUserUnhandledExceptionsAttribute #104813
Merged
halter73
merged 4 commits into
dotnet:main
from
halter73:DebuggerDisableUserUnhandledExceptionsAttribute
Jul 16, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7ca24e2
Add DebuggerDisableUserUnhandledExceptionsAttribute
halter73 c40912d
Add BreakForUserUnhandledException to nativeaot Debugger class
halter73 90c9123
Address PR feedback
halter73 41466e2
Merge branch 'main' into DebuggerDisableUserUnhandledExceptionsAttribute
stephentoub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Debugger.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Runtime.CompilerServices; | ||
|
||
namespace System.Diagnostics | ||
{ | ||
public static partial class Debugger | ||
{ | ||
/// <summary> | ||
/// Signals a breakpoint to an attached debugger with the <paramref name="exception"/> details | ||
/// if a .NET debugger is attached with break on user-unhandled exception enabled and a method | ||
/// attributed with DebuggerDisableUserUnhandledExceptionsAttribute calls this method. | ||
/// </summary> | ||
/// <param name="exception">The user-unhandled exception.</param> | ||
[MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.NoOptimization)] | ||
public static void BreakForUserUnhandledException(Exception exception) | ||
{ | ||
} | ||
} | ||
} |
15 changes: 15 additions & 0 deletions
15
...Private.CoreLib/src/System/Diagnostics/DebuggerDisableUserUnhandledExceptionsAttribute.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
namespace System.Diagnostics | ||
{ | ||
/// <summary> | ||
/// If a .NET Debugger is attached which supports the Debugger.BreakForUserUnhandledException(Exception) API, | ||
/// this attribute will prevent the debugger from breaking on user-unhandled exceptions when the | ||
/// exception is caught by a method with this attribute, unless BreakForUserUnhandledException is called. | ||
/// </summary> | ||
[AttributeUsage(AttributeTargets.Method)] | ||
public sealed class DebuggerDisableUserUnhandledExceptionsAttribute : Attribute | ||
{ | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably isn't going to make much of a difference, but should we add this new attribute to
runtime/src/libraries/System.Private.CoreLib/src/ILLink/ILLink.LinkAttributes.Shared.xml
Lines 2 to 31 in d710379
That way it gets trimmed when DebuggerSupport is off.