[eventpipe][tests] Reenable eventsourceerror non-arm32 unix platforms #105033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
3 tasks
|
Re-enabling the eventsourceerror tests for all unix targets running on CoreCLR Runtime seemed to pass for the first build 744924, so the sigsegv might be hard to reproduce It doesn't seem like eventsourceerror is running on iOS/tvOS/maccatalyst even after removing the test skips in issues.targets. |
mdh1418
force-pushed
the
event_source_error_more_diagnostics
branch
from
6f22fa9
to
f5c218c
Compare
davmason
approved these changes
Jul 17, 2024
mdh1418
changed the title
This was referenced Jul 18, 2024
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables tracing/eventpipe/eventsourceerror that was disabled in #80666 for non-arm32 unix platforms.
From the build #80666 (comment) where the latest crash occurred, the dump collected was investigated in #80666 (comment) and found to be partial and with insufficient information to easily pinpoint the problem. We suspect that the incomplete dump is due to the crash occurring on arm32, so this PR reenables the test for non-arm32 unix platforms in hopes that if the test flakes again, there will be a more complete dump that will be easier to investigate.