Add a thread pool config var on Windows for choosing the number of IOCPs #105145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @mangod9 |
kouvel
commented
Jul 19, 2024
Comment on lines
+44
to
+55
| #if TARGET_WINDOWS | ||
| // Continuations of IO completions are dispatched to the ThreadPool from IO completion poller threads. This avoids | ||
| // continuations blocking/stalling the IO completion poller threads. Setting UnsafeInlineIOCompletionCallbacks allows | ||
| // continuations to run directly on the IO completion poller thread, but is inherently unsafe due to the potential for | ||
| // those threads to become stalled due to blocking. Sometimes, setting this config value may yield better latency. The | ||
| // config value is named for consistency with SocketAsyncEngine.Unix.cs. | ||
| private static readonly bool UnsafeInlineIOCompletionCallbacks = | ||
| Environment.GetEnvironmentVariable("DOTNET_SYSTEM_NET_SOCKETS_INLINE_COMPLETIONS") == "1"; | ||
|
|
||
| private static readonly short IOCompletionPortCount = DetermineIOCompletionPortCount(); | ||
| private static readonly int IOCompletionPollerCount = DetermineIOCompletionPollerCount(); | ||
| #endif |
There was a problem hiding this comment.
These are now used by the constructor, which runs when ThreadPoolInstance is being initialized, so they need to be initialized before ThreadPoolInstance to have the correct values, moved them here to ensure that.
This was referenced Jul 19, 2024
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Open
There were cases where using more than one IOCP was beneficial along with some other changes. Being able to configure the number would be useful for folks to do further testing without having to use private binaries.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were cases where using more than one IOCP was beneficial along with some other changes. Being able to configure the number would be useful for folks to do further testing without having to use private binaries.