-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor memory copies in SafeBuffer
#105206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Jul 21, 2024
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Jul 21, 2024
@MihuBot -arm64 |
This was referenced Jul 22, 2024
Closed
xtqqczze
force-pushed
the
SafeBuffer-Memmove
branch
from
July 22, 2024 17:21
1ecb4be
to
60398d7
Compare
@MihuBot -arm64 |
This was referenced Jul 22, 2024
xtqqczze
force-pushed
the
SafeBuffer-Memmove
branch
from
July 27, 2024 13:59
60398d7
to
b6797f0
Compare
This was referenced Jul 27, 2024
am11
added
area-System.Runtime.InteropServices
and removed
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Aug 6, 2024
Tagging subscribers to this area: @dotnet/interop-contrib |
xtqqczze
force-pushed
the
SafeBuffer-Memmove
branch
from
August 8, 2024 15:05
b6797f0
to
3036449
Compare
@tannergooding Do you want to take a look at this? |
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/SafeBuffer.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/SafeBuffer.cs
Show resolved
Hide resolved
tannergooding
approved these changes
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Runtime.InteropServices
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No diffs expected, except from the changes to sign-extension.Diffs are an improvement: MihuBot/runtime-utils#548
System.Runtime.InteropServices.SafeBuffer:Read[ubyte](ulong):ubyte:this