Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guid(Int32, Int16, Int16, Byte[]) changes #105208

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Guid(Int32, Int16, Int16, Byte[]) changes #105208

merged 4 commits into from
Jul 22, 2024

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 21, 2024 •
edited
Loading

  • Write bytes in order as the JIT can now elide the bounds check.
  • Avoid use of this constructor (saves an array allocation).

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 21, 2024
@Wraith2
Copy link
Contributor

Wraith2 commented Jul 22, 2024

Is there any evidence that this is an improvement?

This was referenced Jul 22, 2024
Closed
Closed
@xtqqczze
Copy link
Contributor Author

@MihuBot

@MihuBot MihuBot mentioned this pull request Jul 22, 2024
Open
@xtqqczze xtqqczze changed the title Copy byte array as block in Guid ctor Guid(Int32, Int16, Int16, Byte[]) changes Jul 22, 2024
@xtqqczze xtqqczze mentioned this pull request Jul 22, 2024
Open
@stephentoub
Copy link
Member

What is the purpose of this PR at this point?

@xtqqczze
Copy link
Contributor Author

Reverted the unsafe changes in favour of a minimal PR.

@xtqqczze xtqqczze marked this pull request as ready for review July 22, 2024 17:11
@xtqqczze
Copy link
Contributor Author

What is the purpose of this PR at this point?

Updated the description.

This was referenced Jul 22, 2024
Open
Open
@xtqqczze
Copy link
Contributor Author

@MihuBot

@MihuBot MihuBot mentioned this pull request Jul 22, 2024
Open
@xtqqczze
Copy link
Contributor Author

@MihuBot

@MihuBot MihuBot mentioned this pull request Jul 22, 2024
Open
stephentoub
stephentoub approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub stephentoub merged commit ea2ffbd into dotnet:main Jul 22, 2024
143 of 147 checks passed
@xtqqczze
Copy link
Contributor Author

@MihuBot

@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@colejohnson66 colejohnson66 colejohnson66 left review comments

@danmoseley danmoseley danmoseley left review comments

@stephentoub stephentoub stephentoub approved these changes

@EgorBo EgorBo EgorBo left review comments

Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xtqqczze @Wraith2 @stephentoub @EgorBo @danmoseley @colejohnson66