Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Rename module file to .mjs #105303

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[wasm] Rename module file to .mjs #105303

wants to merge 4 commits into from
+27 −27

Conversation

mkhamoyan
Copy link
Contributor

Rename test-main.js to test-main.mjs

@mkhamoyan mkhamoyan added arch-wasm WebAssembly architecture os-wasi Related to WASI variant of arch-wasm os-browser Browser variant of arch-wasm labels Jul 23, 2024
@mkhamoyan mkhamoyan self-assigned this Jul 23, 2024
@mkhamoyan
Copy link
Contributor Author

/azp run runtime-wasm

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @directhex, @matouskozak
See info in area-owners.md if you want to be subscribed.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 23, 2024
Open
Closed
Open
Open
Open
Open
@ilonatommy
Copy link
Member

What about this place in the code:

@mkhamoyan
Copy link
Contributor Author

What about this place in the code:

Thanks, updated.

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan mkhamoyan added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 26, 2024
@mkhamoyan mkhamoyan marked this pull request as ready for review July 26, 2024 08:21
@build-analysis build-analysis bot mentioned this pull request Jul 26, 2024
Open
This was referenced Jul 26, 2024
Open
Open
maraf

This comment was marked as outdated.

Sign in to view

@mkhamoyan
Copy link
Contributor Author

@maraf same failure is happeing on my this PR
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-105561-merge-2ba2a3dd38fd4dfcbc/WasmTestOnNodeJS-ST-System.Net.Http.Functional.Tests/1/console.c6060693.log?helixlogtype=result

@pavelsavara pavelsavara assigned pavelsavara and unassigned mkhamoyan Nov 19, 2024
This was referenced Nov 19, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraf maraf maraf left review comments

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) os-browser Browser variant of arch-wasm os-wasi Related to WASI variant of arch-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkhamoyan @ilonatommy @maraf @pavelsavara