ARM64-SVE: Use emitIns_R_R_Imm to handle large immediates correctly
#105958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
jakobbotsch
approved these changes
Aug 5, 2024
a74nh
approved these changes
Aug 5, 2024
The repro for the initial failure is quite large, and I haven't had much luck in pruning it while maintaining the repro. Are we ok with checking in a regression test this big? |
|
Yeah, I would skip the regression test when it's that large. The immediate may be the local's stack offset, so to prune it you may need to replace some locals with large stack locals that take up a lot of stack space. Hmm, perhaps a stress mode would be in order... |
This was referenced Aug 5, 2024
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Open
|
/ba-g blocked by dead-lettering tests from Azure outage |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105954. cc @dotnet/arm64-contrib