Expand an optimization for short values to IgnoreCase in single-value SearchValues<string> #108368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For values length 2 or 3, we have a special case where we don't verify matches at all if we know that false positives are impossible when all the anchors match.
runtime/src/libraries/System.Private.CoreLib/src/System/SearchValues/Strings/SingleStringSearchValuesThreeChars.cs
Lines 362 to 366 in ba9b3ba
We were using this trick with case-sensitive comparisons, but it's actually also valid if we know that all the characters are ASCII letters, so this PR extends the optimization to apply to those values as well.