-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cdac] ExecutionManager contract and RangeSectionMap lookup unit tests #108685
Merged
Commits on Oct 10, 2024
-
[cdac] ExecutionManager contract and lookup map tests
* add RangeSectionMap docs * exhaustively test RangeSectionMap.EffectiveBitsForLevel * fix lookup in RangeSection.Find RangeSectionLookupAlgorithm.FindFragment finds the slot containing the range section fragment pointer. Have to dereference it once to get the actual RangeSectionFragment pointer from the slot. This "worked" before because RangeSectionFragment.Next is at offset 0, so the first lookup would have a garbage range, so we would follow the "next" field and get to the correct fragment * make a testable RangeSectionMap.FindFragmentInternal * brief nibble map summary * [cdac] Implement NibbleMap lookup and tests The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader. * NibbleMap: fix bug and add test Previously we incorrectly computed the prior map index when doing the backward linear search * [testing] display Target values in hex in debugger views * MockMemorySpace: simplify ReaderContext there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader * refactor ExecutionManager * ExecutionManager contract the presence of RangeSection.R2RModule is a discriminator for whether we're looking at EE code or R2R code * WIP NibbleMap * WIP JitCodeToMethodInfo * WIP RangeSectionMap
Configuration menu - View commit details
-
Copy full SHA for b146d06 - Browse repository at this point
Copy the full SHA b146d06View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee5616b - Browse repository at this point
Copy the full SHA ee5616bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbeb33a - Browse repository at this point
Copy the full SHA cbeb33aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4af08a - Browse repository at this point
Copy the full SHA c4af08aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cab907 - Browse repository at this point
Copy the full SHA 0cab907View commit details -
Configuration menu - View commit details
-
Copy full SHA for e27de51 - Browse repository at this point
Copy the full SHA e27de51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04cd55f - Browse repository at this point
Copy the full SHA 04cd55fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 848aea2 - Browse repository at this point
Copy the full SHA 848aea2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dca4d8 - Browse repository at this point
Copy the full SHA 4dca4d8View commit details -
cache EECodeInfo based on given code pointer, not start of the method
The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method
Configuration menu - View commit details
-
Copy full SHA for af85abc - Browse repository at this point
Copy the full SHA af85abcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f31e7f2 - Browse repository at this point
Copy the full SHA f31e7f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f3d208 - Browse repository at this point
Copy the full SHA 6f3d208View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89db889 - Browse repository at this point
Copy the full SHA 89db889View commit details -
Configuration menu - View commit details
-
Copy full SHA for cffad93 - Browse repository at this point
Copy the full SHA cffad93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f26c73 - Browse repository at this point
Copy the full SHA 2f26c73View commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7048c4f - Browse repository at this point
Copy the full SHA 7048c4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 159c188 - Browse repository at this point
Copy the full SHA 159c188View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e8fd1c - Browse repository at this point
Copy the full SHA 6e8fd1cView commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f76ec3c - Browse repository at this point
Copy the full SHA f76ec3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 288d4ca - Browse repository at this point
Copy the full SHA 288d4caView commit details -
Configuration menu - View commit details
-
Copy full SHA for a640354 - Browse repository at this point
Copy the full SHA a640354View commit details
Commits on Oct 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 04e7de1 - Browse repository at this point
Copy the full SHA 04e7de1View commit details
Commits on Oct 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2898390 - Browse repository at this point
Copy the full SHA 2898390View commit details -
Configuration menu - View commit details
-
Copy full SHA for d028a59 - Browse repository at this point
Copy the full SHA d028a59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 138c4f0 - Browse repository at this point
Copy the full SHA 138c4f0View commit details -
Apply suggestions from code review
Co-authored-by: Elinor Fung <elfung@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 4b77d68 - Browse repository at this point
Copy the full SHA 4b77d68View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab6d6e6 - Browse repository at this point
Copy the full SHA ab6d6e6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.