Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdac] ExecutionManager contract and RangeSectionMap lookup unit tests #108685

Merged
merged 27 commits into from
Oct 17, 2024

Commits on Oct 10, 2024

  1. [cdac] ExecutionManager contract and lookup map tests

    *  add RangeSectionMap docs
    
    *  exhaustively test RangeSectionMap.EffectiveBitsForLevel
    
    *  fix lookup in RangeSection.Find
    
        RangeSectionLookupAlgorithm.FindFragment finds the slot containing the range section fragment pointer.
        Have to dereference it once to get the actual RangeSectionFragment pointer from the slot.
    
        This "worked" before because RangeSectionFragment.Next is at offset 0, so the first lookup would have a garbage range, so we would follow the "next" field and get to the correct fragment
    
    *   make a testable RangeSectionMap.FindFragmentInternal
    
    *   brief nibble map summary
    
    *   [cdac] Implement NibbleMap lookup and tests
    
        The execution manager uses a nibble map to quickly map program counter
        pointers to the beginnings of the native code for the managed method.
    
        Implement the lookup algorithm for a nibble map.
    
        Start adding unit tests for the nibble map
    
        Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore.  We can use a uniform reader.
    
    *   NibbleMap: fix bug and add test
    
        Previously we incorrectly computed the prior map index when doing the backward linear search
    
    *   [testing] display Target values in hex in debugger views
    
    *   MockMemorySpace: simplify ReaderContext
    
        there's nothing special about the descriptor HeapFragments anymore.  We can use a uniform reader
    
    *   refactor ExecutionManager
    
    *   ExecutionManager contract
    
        the presence of RangeSection.R2RModule is a discriminator for whether we're looking at EE code or R2R code
    
    *   WIP NibbleMap
    
    *   WIP JitCodeToMethodInfo
    
    *   WIP RangeSectionMap
    lambdageek committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b146d06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee5616b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cbeb33a View commit details
    Browse the repository at this point in the history
  4. fixup RangeSectionMapTests

    lambdageek committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c4af08a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0cab907 View commit details
    Browse the repository at this point in the history
  6. one more friend

    lambdageek committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e27de51 View commit details
    Browse the repository at this point in the history
  7. fix typos

    lambdageek committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    04cd55f View commit details
    Browse the repository at this point in the history
  8. markdown cleanup

    lambdageek committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    848aea2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4dca4d8 View commit details
    Browse the repository at this point in the history
  10. cache EECodeInfo based on given code pointer, not start of the method

    The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method
    lambdageek committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    af85abc View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f31e7f2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6f3d208 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    89db889 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    cffad93 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    2f26c73 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    7048c4f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    159c188 View commit details
    Browse the repository at this point in the history
  3. use allocators a bit more

    lambdageek committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6e8fd1c View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    f76ec3c View commit details
    Browse the repository at this point in the history
  2. cleanup test infra

    lambdageek committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    288d4ca View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a640354 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    04e7de1 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. EECodeInfo -> CodeBlock

    lambdageek committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2898390 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d028a59 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    138c4f0 View commit details
    Browse the repository at this point in the history
  4. Apply suggestions from code review

    Co-authored-by: Elinor Fung <elfung@microsoft.com>
    lambdageek and elinor-fung authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4b77d68 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ab6d6e6 View commit details
    Browse the repository at this point in the history