-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] fix 4GB JS interop #109079
Merged
Merged
[browser] fix 4GB JS interop #109079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
os-browser
Browser variant of arch-wasm
labels
Oct 21, 2024
This was referenced Oct 21, 2024
pavelsavara
requested review from
maraf,
ilonatommy and
lewing
as code owners
October 24, 2024 17:17
pavelsavara
requested review from
kg,
maraf and
ilonatommy
and removed request for
lewing,
maraf and
ilonatommy
October 24, 2024 17:17
kg
reviewed
Oct 24, 2024
kg
reviewed
Oct 24, 2024
kg
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the incremental improvements you're making while doing this
ilonatommy
reviewed
Oct 25, 2024
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
This was referenced Oct 25, 2024
maraf
reviewed
Oct 31, 2024
Co-authored-by: Marek Fišera <mara@neptuo.com>
This was referenced Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
os-browser
Browser variant of arch-wasm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is
use on your own risk
Even when we try to make this work, we do not think it's good idea to allocate more than 256MB in a web page.
malloc
which is wrapper overModule._malloc
that returnsuint32
rather than negative number above 2GBIntPtr
asuint32
to JS, because typically it's used as offset to arrayModule
parameter topreRun
and other emscripten events. So that it could be used to test memory.MemoryTest
WBT to waste 2GB before starting the mono runtime.