-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cdac] Implement ISOSDacInterface::GetModule
and IXCLRDataModule::GetFileName
#109133
Merged
elinor-fung
merged 15 commits into
dotnet:main
from
elinor-fung:cdac-xclrmodule-filename
Oct 24, 2024
Merged
[cdac] Implement ISOSDacInterface::GetModule
and IXCLRDataModule::GetFileName
#109133
elinor-fung
merged 15 commits into
dotnet:main
from
elinor-fung:cdac-xclrmodule-filename
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @tommcdon |
elinor-fung
commented
Oct 22, 2024
This was referenced Oct 23, 2024
This was referenced Oct 23, 2024
lambdageek
reviewed
Oct 23, 2024
lambdageek
reviewed
Oct 23, 2024
lambdageek
approved these changes
Oct 23, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClrDataModule
to cDAC as its implementation ofIXCLRDataModule
andIXCLRDataModule2
GetFileName
ICustomQueryInterface
to handle QI-ing the legacy DAC forIMetaDataImport
ISOSDacInterface::GetModule
ClrDataModule
Module
GetFileName
toLoader
contractIXClrDataModule::GetFileName
Contributes to #99302, #108553
cc @AaronRobinsonMSFT @davidwrighton