Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete pragma suppression for warning disabled with UnconditionalSuppressMessage #110030

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

MichalStrehovsky
Copy link
Member

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@Youssef1313
Copy link
Member

@MichalStrehovsky Is this going to be backported for .NET 8 to avoid the IL3000 in apps?

@MichalStrehovsky
Copy link
Member Author

@MichalStrehovsky Is this going to be backported for .NET 8 to avoid the IL3000 in apps?

The thing that needs backporting is the UnconditionalSuppressMessage on line 73 (that I'm not touching here). Deleting the pragma is not necessary to service.

I believe @rzikm is on top of that.

@rzikm
Copy link
Member

rzikm commented Nov 21, 2024

Thanks, I was planning to address your comment today myself.

Servicing PR is in progress.

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichalStrehovsky MichalStrehovsky merged commit 98049e5 into main Nov 21, 2024
83 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-3 branch November 21, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants