Enable analyzers for mono/netcore

[stephentoub]

cc: @akoeplinger, @marek-safar

This is mostly just running auto-fixers for the various violated rules. In just a few places, I manually intervened.

[danmoseley]

src\libraries\Common\src\Interop\Windows\User32\Interop.GetProcessWindowStation.cs(12,9): error BCL0015: (NETCORE_ENGINEERING_TELEMETRY=Build) user32.dll!GetProcessWindowStation is not supported on one\more targeted platforms

I get the same locally.

I pushed a change to disable it pending #33867

[akoeplinger]

LGTM with one question.

[akoeplinger]

The test failure is the known issue: #34045

[akoeplinger]

@stephentoub by the way how did you run these auto-fixers?

[stephentoub]

@stephentoub by the way how did you run these auto-fixers?

Opened the solution in VS, and used Build | Run Code Analysis on Solution to force all of the analyzers to run promptly. Then for each category, selected one of the warnings from the error list, triggered its fixer from the lightbulb (ctrl-period), and selected Solution when determining the scope to which to apply it. Repeated that for each kind of warning. Then also hacked the .csproj with manually specifying TargetsLinux/OSX/Windows and repeated the process, to cover files only in specific builds.

On that note, how do I build mono's corelib for Linux and macOS? I was able to specify a property on the command-line, and it output the assembly into the relevant location, but it appeared to still be building the Windows source code.

[akoeplinger]

On that note, how do I build mono's corelib for Linux and macOS? I was able to specify a property on the command-line, and it output the assembly into the relevant location, but it appeared to still be building the Windows source code.

As far as I know everything should use the TargetOS msbuild property, same as CoreCLR. What property did you pass?

[stephentoub]

As far as I know everything should use the TargetOS msbuild property, same as CoreCLR. What property did you pass?

That appears to work. No idea what I was doing differently before :)

[danmoseley]

triggered its fixer from the lightbulb (ctrl-period), and selected Solution when determining the scope to which to apply it. Repeated that for each kind of warning.

From a code review point of view, consider making a commit after each fixer. That way I can do only brief review of eg "remove unused usings" and focus on other stuff.