-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rev cmake minimum version from 3.14.2 to 3.14.5 #34757
Rev cmake minimum version from 3.14.2 to 3.14.5 #34757
Conversation
Tagging @ViktorHofer as an area owner |
@jkotas, could we get |
This is a nice-to-have cleanup. The build infrastructure tool updates have fallout and create more work. I think we should save this for when we actually have to do this. Some of the cleanup in this PR is fine. |
src/libraries/Native/Windows/clrcompression/zlib/CMakeLists.txt
Outdated
Show resolved
Hide resolved
If the only work left to do is uploading a newer cmake .zip to netcorenativeassets.blob.core.windows.net then I'd still be in favor of doing it. |
Looks like cmake-3.15.5 is already there: https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/cmake/cmake-3.15.5-win64-x64.zip Given that this is the version documented at https://github.com/dotnet/runtime/blob/master/docs/workflow/requirements/macos-requirements.md#toolchain-setup maybe we should bump the global.json to that (but still keep the |
@akoeplinger, 3.15.5 seems to have more problems on other platforms such as https://gitlab.kitware.com/cmake/cmake/-/issues/20236, around the major version change, so I have kept it to 3.14.5. |
Should this change be part of the next batched rollout after the one in May: #35202? |
FWIW, I do not think we need this update at this point. See #34757 (comment) |
This is a patch version update (not even a minor), which fixes iOS issue and aligns the versions across the board. All non-windows official CI build agents have higher (3.15+) versions installed for a while now. I cannot think of any breakage considering the job of cmake in case of Windows build is mainly to generate vcxproj files and we have CI coverage. |
Yeah I'd still be in favor of doing this cleanup to consolidate the different @ViktorHofer do you have access to upload cmake: #34757 (comment) |
Unfortunately not. @MattGal should have access. |
https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/cmake/cmake-3.14.5-win64-x64.zip and https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/cmake/cmake-3.14.5-win32-x86.zip are there. |
@am11 thanks for the contribution and sorry for the long wait 👍 |
iOS requires 3.14.5 version and we have a special case for it. Since this is a minor version difference, and no distro is particularly providing cmake 3.14.2 package, it is safe to update to 3.14.5 to cover our supported platform matrix.
Discussion: #33959 (comment)
Fixes: #33976
cc @akoeplinger, @jkotas