Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PAL test build on non-Linux Unix platforms #35218

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix PAL test build on non-Linux Unix platforms #35218

merged 1 commit into from
Apr 28, 2020

Conversation

am11
Copy link
Member

@am11 am11 commented Apr 20, 2020

A step towards re-enabling PAL tests in the CI: #34776.

On macOS and Illumos/SmartOS, currently the C11's non-optional header <uchar.h> (not to be confused with ICU's unicode/uchar.h) is not available.

This PR removes the uchar.h usage from PAL tests (which is used for the definition of char16_t) and conditionally declare char16_t for "C sources in PAL tests".

All tests are passing on macOS baremetal, one test failed on Ubuntu x64 virtual machine:

<test name="miscellaneous.queryperformancecounter.test1" type="miscellaneous.queryperformancecounter" method="test1" result="Fail" >
  <failure exception-type="Exit code: 1">
    <message><![CDATA[ERROR:  average diff 59 acceptable 15.]]></message>
  </failure>
</test>

There are currently six failures on SmartOS x64 VM (http://sprunge.us/3eVz48 - file: /tmp/PalTestOutput/default/pal_tests.xml) with #35173 (and libunwind) changes.

cc @janvorli, @rmustacc

@janvorli janvorli merged commit 923b21b into dotnet:master Apr 28, 2020
@am11 am11 deleted the feature/pal-tests branch April 28, 2020 10:37
@am11 am11 mentioned this pull request May 11, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants