Fix PAL test build on non-Linux Unix platforms #35218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step towards re-enabling PAL tests in the CI: #34776.
On macOS and Illumos/SmartOS, currently the C11's non-optional header
<uchar.h>
(not to be confused with ICU'sunicode/uchar.h
) is not available.This PR removes the
uchar.h
usage from PAL tests (which is used for the definition ofchar16_t
) and conditionally declarechar16_t
for "C sources in PAL tests".All tests are passing on macOS baremetal, one test failed on Ubuntu x64 virtual machine:
There are currently six failures on SmartOS x64 VM (http://sprunge.us/3eVz48 - file:
/tmp/PalTestOutput/default/pal_tests.xml
) with #35173 (and libunwind) changes.cc @janvorli, @rmustacc