From 745aafdf2a42e6780ea0141190fe0c009425d784 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Thu, 7 May 2020 17:26:46 -0400 Subject: [PATCH] Remove unnecessary recursive locking from Http2Stream.Complete We just asserted we're holding the lock. We don't need to take it again. --- .../System/Net/Http/SocketsHttpHandler/Http2Stream.cs | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Stream.cs b/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Stream.cs index 2948820a0aab1..6c66a674017b0 100644 --- a/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Stream.cs +++ b/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Stream.cs @@ -329,14 +329,11 @@ private void Complete() _connection.RemoveStream(this); - lock (SyncObject) + CreditWaiter? w = _creditWaiter; + if (w != null) { - CreditWaiter? w = _creditWaiter; - if (w != null) - { - w.Dispose(); - _creditWaiter = null; - } + w.Dispose(); + _creditWaiter = null; } }