Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable JitDoOldStructRetyping by default. #37745

Merged
merged 10 commits into from
Jul 7, 2020

Commits on Jun 28, 2020

  1. Disable retyping by default.

    Sergey Andreenko committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    f432437 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Keep block init/copy as baseline.

    Total bytes of diff: -21971 (-0.07% of base)
    3075 total methods with Code Size differences (1589 improved, 1486 regressed), 184523 unchanged.
    
    Note: it improves code with retyping as well:
    808 total methods with Code Size differences (808 improved, 0 regressed), 186790 unchanged.
    Found 55 files with textual diffs.
    Crossgen CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for  default jit
    Summary of Code Size diffs:
    (Lower is better)
    Total bytes of diff: -22923 (-0.07% of base)
    Sergey Andreenko committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    06e7c52 View commit details
    Browse the repository at this point in the history
  2. Don't mark LCL_VAR that is used in RETURN(IND(ADDR(LCL_VAR)) as addre…

    …ss taken when possible.
    
    Protect against a promoted struct with a hole like struct<8> {hole 4; int a;};
    Sergey Andreenko committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    f53bb30 View commit details
    Browse the repository at this point in the history
  3. Replace 1-field structs with the field for returns.

    Sergey Andreenko committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    3965e9d View commit details
    Browse the repository at this point in the history
  4. Add SSA support.

    Sergey Andreenko committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    f7a90a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Review response.

    Sergey Andreenko committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    8911b08 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. isOpaqueSIMDLclVar fix

    Sergey Andreenko committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    0d8cf17 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Configuration menu
    Copy the full SHA
    c16fc9f View commit details
    Browse the repository at this point in the history
  2. Old retyping fix.

    Sergey Andreenko committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e0fbd5f View commit details
    Browse the repository at this point in the history
  3. Don't try to replace SIMD fields.

    Sergey Andreenko committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    9daf9c1 View commit details
    Browse the repository at this point in the history