Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark some System.Net.HttpListener APIs as unsupported on browser #42063

Merged
merged 6 commits into from
Sep 14, 2020
Merged

Mark some System.Net.HttpListener APIs as unsupported on browser #42063

merged 6 commits into from
Sep 14, 2020

Conversation

MaximLipnin
Copy link
Contributor

DocID Namespace Type Member Nesting
M:System.Net.HttpListenerRequest.get_IsLocal System.Net HttpListenerRequest get_IsLocal() 3
M:System.Net.HttpListenerRequest.get_UserHostAddress System.Net HttpListenerRequest get_UserHostAddress() 3
M:System.Net.HttpListenerRequest.get_LocalEndPoint System.Net HttpListenerRequest get_LocalEndPoint() 2
M:System.Net.HttpListenerRequest.get_RemoteEndPoint System.Net HttpListenerRequest get_RemoteEndPoint() 2
M:System.Net.HttpListener.set_ExtendedProtectionPolicy(System.Security.Authentication.ExtendedProtection.ExtendedProtectionPolicy) System.Net HttpListener set_ExtendedProtectionPolicy(ExtendedProtectionPolicy) 1
M:System.Net.HttpListenerResponse.Close System.Net HttpListenerResponse Close() 3
M:System.Net.HttpListenerResponse.Close(System.Byte[],System.Boolean) System.Net HttpListenerResponse Close(Byte[], Boolean) 3
M:System.Net.HttpListenerResponse.Abort System.Net HttpListenerResponse Abort() 3
M:System.Net.HttpListenerTimeoutManager.set_MinSendBytesPerSecond(System.Int64) System.Net HttpListenerTimeoutManager set_MinSendBytesPerSecond(Int64) 0
M:System.Net.HttpListenerTimeoutManager.set_RequestQueue(System.TimeSpan) System.Net HttpListenerTimeoutManager set_RequestQueue(TimeSpan) 0
M:System.Net.HttpListenerTimeoutManager.set_HeaderWait(System.TimeSpan) System.Net HttpListenerTimeoutManager set_HeaderWait(TimeSpan) 0
M:System.Net.HttpListenerTimeoutManager.set_EntityBody(System.TimeSpan) System.Net HttpListenerTimeoutManager set_EntityBody(TimeSpan) 0

Part of #41087

@ghost
Copy link

ghost commented Sep 10, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@MaximLipnin MaximLipnin mentioned this pull request Sep 10, 2020
Closed
71 tasks
@MaximLipnin
Copy link
Contributor Author

It's odd but I have to mark the respective APIs in the windows-specific classes too in order to avoid the Windows lanes failures like missing the attribute in the implementation.

@kjpou1 kjpou1 merged commit b147bbe into dotnet:master Sep 14, 2020
@MaximLipnin MaximLipnin deleted the system.net_unsupported_on_browser branch September 14, 2020 10:08
mdh1418 pushed a commit to mdh1418/runtime that referenced this pull request Sep 15, 2020
@MaximLipnin
Mark some System.Net.HttpListener APIs as unsupported on browser (dot…
a2b40bc 
…net#42063)

* Mark some System.Net.HttpListener APIs as unsupported on browser

* FIx windows builds

* Fix windows builds

* Remove browser annotations from the properties with windows-specific setters.

* Mark only setter of ExtendedProtectionPolicy

* Remove another redundant annotation
@mdh1418 mdh1418 mentioned this pull request Sep 15, 2020
Merged
lewing pushed a commit that referenced this pull request Sep 16, 2020
@mdh1418 @MaximLipnin
[release/5.0-rc2] Backport Additional Browser Unsupported Attribute C…
c30d4bb 
…hanges (#42267)

* Mark System.IO.Pipes Unsupported at assembly level (#41976)

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>

* Mark some System.Net.Http APIs as unsupported on browser (#42074)

* Mark some System.Net.HttpListener APIs as unsupported on browser (#42063)

* Mark some System.Net.HttpListener APIs as unsupported on browser

* FIx windows builds

* Fix windows builds

* Remove browser annotations from the properties with windows-specific setters.

* Mark only setter of ExtendedProtectionPolicy

* Remove another redundant annotation

* Mark System.Security.Cryptography.Algorithms as unsupported on Browser WASM (#42010)

* Mark System.Security.Cryptography.Algorithms as unsupported on Browser WASM

* Address the comment regarding IncrementalHash.CreateHMAC

* Group System.* usings

* Restore the blank lines between the meta-comment and the code for all the HMAC classes

* Fix style issues

* Mark MD5 class as unsupported on Browser; clean up the api exclusion list and proj file.

* Using

* Style fix

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
Co-authored-by: Maxim Lipnin <v-maxlip@microsoft.com>
@runfoapp runfoapp bot mentioned this pull request Sep 29, 2020
Closed
@MaximLipnin MaximLipnin mentioned this pull request Oct 14, 2020
Merged
2 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdh1418 mdh1418 mdh1418 approved these changes

@steveisok steveisok Awaiting requested review from steveisok

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
area-System.Net.Http
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MaximLipnin @mdh1418 @kjpou1 @karelz @Dotnet-GitSync-Bot