-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring superhost build #42759
Closed
Closed
Refactoring superhost build #42759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @vitek-karas, @agocke |
VSadov
force-pushed
the
libQcalls
branch
6 times, most recently
from
September 27, 2020 22:07
7c9dd89
to
2d971ca
Compare
VSadov
force-pushed
the
libQcalls
branch
2 times, most recently
from
September 29, 2020 13:25
79c446f
to
d39f063
Compare
This was referenced Sep 29, 2020
VSadov
force-pushed
the
libQcalls
branch
2 times, most recently
from
September 30, 2020 12:30
186e568
to
f8e6539
Compare
This was referenced Sep 30, 2020
table format GetRLimit, SetRLimit
… (because implementation is)
Please stop submitting work from this PR until you can take an Arcade update containing the changes within dotnet/arcade#6315 |
I will close the PR for now, just to be sure it does not re-run something due to accidental push or touching the UI. |
ghost
locked as resolved and limited conversation to collaborators
Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point this is just to run tests. This is not the final form.
In this configuration:
Matching the flavor of coreclr when linking together the host is desirable and will be a requirement on Windows where linker requires Debug/Release match.
On tricky remaining point is automated creation of QCall tables.
In this iteration, the tables are created by copy/pasting the output form a tool which scans metadata of Libraries, CoreLib and test helpers. Yet a few entry points had to be added manually. (mostly due to tree shaking of managed libs and the scan not seeing 100% of callers).
This part needs some rethinking. Perhaps we should scan native .h files and parse PALEXPORT entries instead.
OSX has an extra crypto lib. That is NYI and will likely fail to build.