Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring superhost build #42759

Closed
wants to merge 27 commits into from
Closed

Refactoring superhost build #42759

wants to merge 27 commits into from

Conversation

VSadov
Copy link
Member

@VSadov VSadov commented Sep 25, 2020

At this point this is just to run tests. This is not the final form.

In this configuration:

  • native libraries are built as a part of coreclr build.
  • native libraries are linked into coreclr, even in a regular (not single-file) scenario - that is to ensure a good test coverage.
  • native dll are also built (as they will be as a part of regular not singlefile case), but in this configuration they are not used.
  • hosting layer picks native libraries produced by coreclr. - I.E. if the coreclr build is Checked, the native libs will have Checked flavor regardless of the flavor of managed Libraries.
    Matching the flavor of coreclr when linking together the host is desirable and will be a requirement on Windows where linker requires Debug/Release match.

On tricky remaining point is automated creation of QCall tables.
In this iteration, the tables are created by copy/pasting the output form a tool which scans metadata of Libraries, CoreLib and test helpers. Yet a few entry points had to be added manually. (mostly due to tree shaking of managed libs and the scan not seeing 100% of callers).

This part needs some rethinking. Perhaps we should scan native .h files and parse PALEXPORT entries instead.

OSX has an extra crypto lib. That is NYI and will likely fail to build.

@ghost
Copy link

ghost commented Sep 25, 2020

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

@MattGal
Copy link
Member

MattGal commented Oct 2, 2020

Please stop submitting work from this PR until you can take an Arcade update containing the changes within dotnet/arcade#6315

@VSadov
Copy link
Member Author

VSadov commented Oct 2, 2020

I will close the PR for now, just to be sure it does not re-run something due to accidental push or touching the UI.

@VSadov VSadov closed this Oct 2, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants