Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in XDocumentType #44868

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Fix regression in XDocumentType #44868

merged 1 commit into from
Nov 19, 2020

Conversation

krwq
Copy link
Member

@krwq krwq commented Nov 18, 2020 •
edited
Loading

Fixes: #44489

@ghost
Copy link

ghost commented Nov 18, 2020

Tagging subscribers to this area: @buyaa-n, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.

Issue Details
Description:

Fixes regression in: #44489
Author: krwq
Assignees: stephentoub, Jozkee, buyaa-n
Labels:

area-System.Xml
Milestone: -

@stephentoub
Copy link
Member

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@stephentoub
Copy link
Member

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephentoub stephentoub mentioned this pull request Nov 18, 2020
Closed
@jeffhandley
Copy link
Member

@krwq Please include these changes into our accumulated list of nullable annotation changes in 6.0.

jozkee
jozkee approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source changes LGTM.

@krwq krwq added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Nov 19, 2020
@krwq
Copy link
Member Author

krwq commented Nov 19, 2020

The failures don't seem to be related, merging

@krwq krwq merged commit a7040b0 into dotnet:master Nov 19, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Sep 29, 2021
@ericstj ericstj added this to the 6.0.0 milestone Sep 29, 2021
@ericstj ericstj assigned krwq and unassigned stephentoub, jozkee and buyaa-n Sep 30, 2021
@jeffhandley jeffhandley removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jozkee jozkee jozkee approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees

@krwq krwq

Labels
area-System.Xml breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

regression in SimpleConstructors test inside System.Xml.Linq.TreeManipulation.Tests
6 participants
@krwq @stephentoub @jeffhandley @jozkee @ericstj @buyaa-n