Fix dependency version & packageVersion in runtime.native.system.io.ports #47732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern, @ViktorHofer Issue DetailsFixes #47268
|
This was referenced Feb 2, 2021
ViktorHofer
approved these changes
Feb 2, 2021
Anipik
changed the title
safern
reviewed
Feb 2, 2021
| ], | ||
| "InboxOn": {} | ||
| }, | ||
| "runtime.osx-x64.runtime.native.System.IO.Ports": { |
There was a problem hiding this comment.
What happens if we add new rids, do we have to be adding more entries here? I don't know if there is a better way long term. For 5.0.0 fix, it seems good as is, but maybe we can come with a better way long term.
There was a problem hiding this comment.
In 6.0 the package index will hopefully go away.
ericstj
reviewed
Feb 2, 2021
ericstj
requested changes
Feb 4, 2021
|
taking label off until it's ready to go |
|
Also @Anipik can you please update the template content above to your improved version that is clearer eg about the customer impact of the current state. |
|
Approved over mail |
ericstj
reviewed
Feb 4, 2021
ericstj
approved these changes
Feb 4, 2021
|
Failures are related to this #46837 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47268
Description
We shipped runtime.native.system.io.ports package with non-stable dependencies
Nuget.exe fails to install the package with specific targetFramework
eg. NuGet.exe install System.IO.Ports -Version 5.0.0 -outputdirectory ioports -Framework net5.0 -Verbosity detailed
We also never shipped the stable 5.0 version
of these packages.
The fix is shipping 5.0.0 stable version of runtime specific packages and 5.0.1 version of runtime.native.system.io.ports with 5.0.0 dependencies
Customer Impact
Nuget pack does not allow to have a stable package depend on non-stable packages.
Customers lack confidence in our packages due to non-stable suffix. There wont be any functional change.
Regression
yes, in 3.1 we shipped the stable versions of runtime specific packages
Testing
Used package explorer to check the dependency versions.
Verified with nuget.exe install works using a local feed.
Risk
Low, we are changing the packageIndex.json to fix this. The major use of PackageIndex is used to calculate the dependency version in packages. However, the change is very specific to few packages.