Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off PGO builds until I can get a proper fix in #48170

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

agocke
Copy link
Member

@agocke agocke commented Feb 11, 2021

I think the fix here is to make the artifacts include pgo info in the name so the builds don't cross each other, but that may take a few tries to get right.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@agocke agocke requested review from ViktorHofer and safern February 11, 2021 17:23
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if that's sufficient to fix the manifest errors.

@ghost
Copy link

ghost commented Feb 11, 2021

Hello @agocke!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@agocke
Copy link
Member Author

agocke commented Feb 11, 2021

It should be -- the errors only happen because pgort is present in the output, but I think (checked locally) that pgort doesn't get copied in the regular builds.

@agocke
Copy link
Member Author

agocke commented Feb 12, 2021

Looks like just a flaky networking test, merging

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants