Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer microsoft.com certificate chain in X.509 tests #48460

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

vcsjones
Copy link
Member

The old certificate chain used a root certificate that is deprecated and is starting to disappear from some trust stores in Linux. The removal of the root certificate led to a few failing tests, and other tests not running since they were conditional on the trust of that certificate.

Closes #48406

The old certificate chain used a root certificate that is deprecated
and is starting to disappear from some trust stores. The removal of
the root certificate led to a few failing tests, and other tests not
running since they were conditional on the trust of that certificate.
@ghost
Copy link

ghost commented Feb 18, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

The old certificate chain used a root certificate that is deprecated and is starting to disappear from some trust stores in Linux. The removal of the root certificate led to a few failing tests, and other tests not running since they were conditional on the trust of that certificate.

Closes #48406

Author: vcsjones
Assignees: -
Labels:

area-System.Security

Milestone: -

@vcsjones
Copy link
Member Author

This will need an outerloop run.

@bartonjs
Copy link
Member

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vcsjones
Copy link
Member Author

Outerloop failures appear irrelevant.

@bartonjs
Copy link
Member

Outerloop failures appear irrelevant.

I agree. Thanks, @vcsjones.

@Anipik
Copy link
Contributor

Anipik commented Mar 10, 2021

@bartonjs @vcsjones can you port the fix to 5.0 branch, we are hitting the same issue there

@vcsjones
Copy link
Member Author

@bartonjs I don't think backport bot will be able to do this one cleanly, I'll prepare a PR for a manual backport.

@vcsjones
Copy link
Member Author

@Anipik it looks like this was backported yesterday to release/5.0 in #49300.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S.S.C.X509Certificates.Tests.ChainTests.BuildChainCustomTrustStore failing locally
3 participants