Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax chain status for building an invalid chain. #55231

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Jul 6, 2021

The chain results can be either PartialChain or NotSignatureValid depending on what we get back from the underlying platform. This relaxes the test so that both are acceptable.

Closes #48851.

The chain results can be either PartialChain or NotSignatureValid
depending on what we get back from the underlying platform. This
relaxes the test so that both are acceptable.
@ghost
Copy link

ghost commented Jul 6, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

The chain results can be either PartialChain or NotSignatureValid depending on what we get back from the underlying platform. This relaxes the test so that both are acceptable.

Closes #48851.

Author: vcsjones
Assignees: -
Labels:

area-System.Security

Milestone: -

@stephentoub stephentoub merged commit a285302 into dotnet:main Jul 7, 2021
@vcsjones vcsjones deleted the fix-48851 branch July 7, 2021 03:00
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildInvalidSignatureTwice
3 participants