Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update MsQuic version #55291

Merged
merged 2 commits into from
Jul 8, 2021
Merged

update MsQuic version #55291

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a14d42c
update MsQuic version
wfurt Jul 7, 2021
b6b0332
add also Versions.props
wfurt Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<Uri>https://github.com/dotnet/icu</Uri>
<Sha>e7626ad8c04b150de635f920b5e8dede0aafaf73</Sha>
</Dependency>
<Dependency Name="System.Net.MsQuic.Transport" Version="6.0.0-preview.7.21328.2">
<Dependency Name="System.Net.MsQuic.Transport" Version="6.0.0-preview.7.21357.1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok that <Sha> wasn't changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so but I'm not 100% cc: @safern
I think the sha is updated when this update is done with darc/maestro.
I did build/restore and I see new version restored in Nuget cache.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the sha is updated by darc/maestro. However you can also update it manually yourself, but it is not a deal breaker if we don't do it.

<Uri>https://github.com/dotnet/msquic</Uri>
<Sha>d7db669b70f4dd67ec001c192f9809c218cab88b</Sha>
</Dependency>
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ public async Task TestConnect()
Assert.Equal(ApplicationProtocol.ToString(), serverConnection.NegotiatedApplicationProtocol.ToString());
}

// this started to fail after updating msquic from cc104e836a5d4a5e0d324bc08b42136d2acac997 to 8e21db733f22533a613d404d2a86e64588019132
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
[Fact]
public async Task AcceptStream_ConnectionAborted_ByClient_Throws()
{
Expand Down