From eb99a9732da0aa18aa232e4524d1251b4a3ab3c9 Mon Sep 17 00:00:00 2001 From: Maksym Koshovyi Date: Sun, 15 Aug 2021 10:30:53 +0300 Subject: [PATCH 1/8] Annotate --- ...Microsoft.Extensions.Configuration.CommandLine.cs | 6 +++--- ...osoft.Extensions.Configuration.CommandLine.csproj | 8 +++++++- .../src/CommandLineConfigurationExtensions.cs | 2 +- .../src/CommandLineConfigurationProvider.cs | 12 ++++++------ .../src/CommandLineConfigurationSource.cs | 5 +++-- ...osoft.Extensions.Configuration.CommandLine.csproj | 9 ++++++++- 6 files changed, 28 insertions(+), 14 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.cs b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.cs index 0e629f4f11569..02874a07ec9ca 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.cs +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.cs @@ -10,14 +10,14 @@ public static partial class CommandLineConfigurationExtensions { public static Microsoft.Extensions.Configuration.IConfigurationBuilder AddCommandLine(this Microsoft.Extensions.Configuration.IConfigurationBuilder builder, System.Action configureSource) { throw null; } public static Microsoft.Extensions.Configuration.IConfigurationBuilder AddCommandLine(this Microsoft.Extensions.Configuration.IConfigurationBuilder configurationBuilder, string[] args) { throw null; } - public static Microsoft.Extensions.Configuration.IConfigurationBuilder AddCommandLine(this Microsoft.Extensions.Configuration.IConfigurationBuilder configurationBuilder, string[] args, System.Collections.Generic.IDictionary switchMappings) { throw null; } + public static Microsoft.Extensions.Configuration.IConfigurationBuilder AddCommandLine(this Microsoft.Extensions.Configuration.IConfigurationBuilder configurationBuilder, string[] args, System.Collections.Generic.IDictionary? switchMappings) { throw null; } } } namespace Microsoft.Extensions.Configuration.CommandLine { public partial class CommandLineConfigurationProvider : Microsoft.Extensions.Configuration.ConfigurationProvider { - public CommandLineConfigurationProvider(System.Collections.Generic.IEnumerable args, System.Collections.Generic.IDictionary switchMappings = null) { } + public CommandLineConfigurationProvider(System.Collections.Generic.IEnumerable args, System.Collections.Generic.IDictionary? switchMappings = null) { } protected System.Collections.Generic.IEnumerable Args { get { throw null; } } public override void Load() { } } @@ -25,7 +25,7 @@ public partial class CommandLineConfigurationSource : Microsoft.Extensions.Confi { public CommandLineConfigurationSource() { } public System.Collections.Generic.IEnumerable Args { get { throw null; } set { } } - public System.Collections.Generic.IDictionary SwitchMappings { get { throw null; } set { } } + public System.Collections.Generic.IDictionary? SwitchMappings { get { throw null; } set { } } public Microsoft.Extensions.Configuration.IConfigurationProvider Build(Microsoft.Extensions.Configuration.IConfigurationBuilder builder) { throw null; } } } diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj index 041fb7e77f76f..518672091b038 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj @@ -1,10 +1,16 @@ - netstandard2.0;net461 + $(NetCoreAppCurrent);netstandard2.0;net461 + enable + + + + + diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationExtensions.cs b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationExtensions.cs index c5e7ee43326fb..cfeee2ecc5c31 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationExtensions.cs +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationExtensions.cs @@ -152,7 +152,7 @@ public static IConfigurationBuilder AddCommandLine(this IConfigurationBuilder co public static IConfigurationBuilder AddCommandLine( this IConfigurationBuilder configurationBuilder, string[] args, - IDictionary switchMappings) + IDictionary? switchMappings) { configurationBuilder.Add(new CommandLineConfigurationSource { Args = args, SwitchMappings = switchMappings }); return configurationBuilder; diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationProvider.cs b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationProvider.cs index fb1b17a521630..a41d6f541d02f 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationProvider.cs +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationProvider.cs @@ -11,14 +11,14 @@ namespace Microsoft.Extensions.Configuration.CommandLine /// public class CommandLineConfigurationProvider : ConfigurationProvider { - private readonly Dictionary _switchMappings; + private readonly Dictionary? _switchMappings; /// /// Initializes a new instance. /// /// The command line args. /// The switch mappings. - public CommandLineConfigurationProvider(IEnumerable args, IDictionary switchMappings = null) + public CommandLineConfigurationProvider(IEnumerable args, IDictionary? switchMappings = null) { Args = args ?? throw new ArgumentNullException(nameof(args)); @@ -38,7 +38,7 @@ public CommandLineConfigurationProvider(IEnumerable args, IDictionary public override void Load() { - var data = new Dictionary(StringComparer.OrdinalIgnoreCase); + var data = new Dictionary(StringComparer.OrdinalIgnoreCase); string key, value; using (IEnumerator enumerator = Args.GetEnumerator()) @@ -68,7 +68,7 @@ public override void Load() if (separator < 0) { - // If there is neither equal sign nor prefix in current arugment, it is an invalid format + // If there is neither equal sign nor prefix in current argument, it is an invalid format if (keyStartIndex == 0) { // Ignore invalid formats @@ -76,7 +76,7 @@ public override void Load() } // If the switch is a key in given switch mappings, interpret it - if (_switchMappings != null && _switchMappings.TryGetValue(currentArg, out string mappedKey)) + if (_switchMappings != null && _switchMappings.TryGetValue(currentArg, out string? mappedKey)) { key = mappedKey; } @@ -105,7 +105,7 @@ public override void Load() string keySegment = currentArg.Substring(0, separator); // If the switch is a key in given switch mappings, interpret it - if (_switchMappings != null && _switchMappings.TryGetValue(keySegment, out string mappedKeySegment)) + if (_switchMappings != null && _switchMappings.TryGetValue(keySegment, out string? mappedKeySegment)) { key = mappedKeySegment; } diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationSource.cs b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationSource.cs index 36a665e360a48..1dc7ad911811c 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationSource.cs +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationSource.cs @@ -1,6 +1,7 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. +using System; using System.Collections.Generic; namespace Microsoft.Extensions.Configuration.CommandLine @@ -13,12 +14,12 @@ public class CommandLineConfigurationSource : IConfigurationSource /// /// Gets or sets the switch mappings. /// - public IDictionary SwitchMappings { get; set; } + public IDictionary? SwitchMappings { get; set; } /// /// Gets or sets the command line args. /// - public IEnumerable Args { get; set; } + public IEnumerable Args { get; set; } = Array.Empty(); /// /// Builds the for this source. diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj index e86f2b36065ff..8a2a55d1f786b 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj @@ -1,7 +1,8 @@ - netstandard2.0;net461 + $(NetCoreAppCurrent);netstandard2.0;net461 + enable true Command line configuration provider implementation for Microsoft.Extensions.Configuration. @@ -11,4 +12,10 @@ + + + + + + From 3af608f5be1b2956608ed40303fc1074b7ef2fda Mon Sep 17 00:00:00 2001 From: Maksym Koshovyi Date: Sun, 15 Aug 2021 10:33:37 +0300 Subject: [PATCH 2/8] Add net6 to parent projects --- ...icrosoft.Extensions.Configuration.Abstractions.csproj | 7 ++++++- ...icrosoft.Extensions.Configuration.Abstractions.csproj | 8 +++++++- .../ref/Microsoft.Extensions.Configuration.csproj | 8 +++++++- .../src/Microsoft.Extensions.Configuration.csproj | 9 ++++++++- 4 files changed, 28 insertions(+), 4 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.csproj b/src/libraries/Microsoft.Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.csproj index d6b7d921c7a1e..6e440984e4a8f 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.csproj +++ b/src/libraries/Microsoft.Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.csproj @@ -1,6 +1,6 @@ - netstandard2.0;net461 + $(NetCoreAppCurrent);netstandard2.0;net461 @@ -8,4 +8,9 @@ + + + + + diff --git a/src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/Microsoft.Extensions.Configuration.Abstractions.csproj b/src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/Microsoft.Extensions.Configuration.Abstractions.csproj index 24cbc9380f00f..7a6e08ed66c2e 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/Microsoft.Extensions.Configuration.Abstractions.csproj +++ b/src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/Microsoft.Extensions.Configuration.Abstractions.csproj @@ -1,7 +1,7 @@ - netstandard2.0;net461 + $(NetCoreAppCurrent);netstandard2.0;net461 true Abstractions of key-value pair based configuration. @@ -21,4 +21,10 @@ Microsoft.Extensions.Configuration.IConfigurationSection + + + + + + diff --git a/src/libraries/Microsoft.Extensions.Configuration/ref/Microsoft.Extensions.Configuration.csproj b/src/libraries/Microsoft.Extensions.Configuration/ref/Microsoft.Extensions.Configuration.csproj index e1533c3eadf9e..f95d70cb8227e 100644 --- a/src/libraries/Microsoft.Extensions.Configuration/ref/Microsoft.Extensions.Configuration.csproj +++ b/src/libraries/Microsoft.Extensions.Configuration/ref/Microsoft.Extensions.Configuration.csproj @@ -1,10 +1,16 @@ - netstandard2.0;net461 + $(NetCoreAppCurrent);netstandard2.0;net461 + + + + + + diff --git a/src/libraries/Microsoft.Extensions.Configuration/src/Microsoft.Extensions.Configuration.csproj b/src/libraries/Microsoft.Extensions.Configuration/src/Microsoft.Extensions.Configuration.csproj index 62243f8db8537..76056af7e3dc7 100644 --- a/src/libraries/Microsoft.Extensions.Configuration/src/Microsoft.Extensions.Configuration.csproj +++ b/src/libraries/Microsoft.Extensions.Configuration/src/Microsoft.Extensions.Configuration.csproj @@ -1,7 +1,7 @@ - netstandard2.0;net461 + $(NetCoreAppCurrent);netstandard2.0;net461 true Implementation of key-value pair based configuration for Microsoft.Extensions.Configuration. Includes the memory configuration provider. @@ -11,4 +11,11 @@ + + + + + + + From dbd2ace2c18cdce19313fd5e75275d5a35678b8d Mon Sep 17 00:00:00 2001 From: Maksym Koshovyi Date: Fri, 27 Aug 2021 01:09:02 +0300 Subject: [PATCH 3/8] DisableImplicitAssemblyReferences --- .../Microsoft.Extensions.Configuration.CommandLine.csproj | 5 ++--- .../Microsoft.Extensions.Configuration.CommandLine.csproj | 8 ++------ 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj index 518672091b038..1800acf8ccb79 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj @@ -9,8 +9,7 @@ - - - + + diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj index 8a2a55d1f786b..74447206f04e5 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj @@ -4,6 +4,8 @@ $(NetCoreAppCurrent);netstandard2.0;net461 enable true + + false Command line configuration provider implementation for Microsoft.Extensions.Configuration. @@ -12,10 +14,4 @@ - - - - - - From 87fa7c8ce8d65392f18cc3231baf5a909e40bc1e Mon Sep 17 00:00:00 2001 From: Maksym Koshovyi Date: Fri, 19 Nov 2021 11:20:12 +0200 Subject: [PATCH 4/8] NetCoreAppMinimum --- .../ref/Microsoft.Extensions.Configuration.CommandLine.csproj | 2 +- .../src/Microsoft.Extensions.Configuration.CommandLine.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj index 1ad9281c2a6d3..8c01e0006ecf3 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj @@ -1,6 +1,6 @@ - $(NetCoreAppCurrent);netstandard2.0;$(NetFrameworkMinimum) + $(NetCoreAppCurrent);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum) enable diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj index c758a47256ef8..bf8e1cce4abb2 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/Microsoft.Extensions.Configuration.CommandLine.csproj @@ -1,7 +1,7 @@ - $(NetCoreAppCurrent);netstandard2.0;$(NetFrameworkMinimum) + $(NetCoreAppCurrent);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum) enable true From 53dbbe6be4879ac48149b115ec0a073d62c651af Mon Sep 17 00:00:00 2001 From: Maksym Koshovyi Date: Fri, 19 Nov 2021 11:22:12 +0200 Subject: [PATCH 5/8] configureSource is nullable --- .../ref/Microsoft.Extensions.Configuration.CommandLine.cs | 2 +- .../src/CommandLineConfigurationExtensions.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.cs b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.cs index 02874a07ec9ca..b1d4b8e21e383 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.cs +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.cs @@ -8,7 +8,7 @@ namespace Microsoft.Extensions.Configuration { public static partial class CommandLineConfigurationExtensions { - public static Microsoft.Extensions.Configuration.IConfigurationBuilder AddCommandLine(this Microsoft.Extensions.Configuration.IConfigurationBuilder builder, System.Action configureSource) { throw null; } + public static Microsoft.Extensions.Configuration.IConfigurationBuilder AddCommandLine(this Microsoft.Extensions.Configuration.IConfigurationBuilder builder, System.Action? configureSource) { throw null; } public static Microsoft.Extensions.Configuration.IConfigurationBuilder AddCommandLine(this Microsoft.Extensions.Configuration.IConfigurationBuilder configurationBuilder, string[] args) { throw null; } public static Microsoft.Extensions.Configuration.IConfigurationBuilder AddCommandLine(this Microsoft.Extensions.Configuration.IConfigurationBuilder configurationBuilder, string[] args, System.Collections.Generic.IDictionary? switchMappings) { throw null; } } diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationExtensions.cs b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationExtensions.cs index cfeee2ecc5c31..b39998e4d91d7 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationExtensions.cs +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/src/CommandLineConfigurationExtensions.cs @@ -164,7 +164,7 @@ public static IConfigurationBuilder AddCommandLine( /// The to add to. /// Configures the source. /// The . - public static IConfigurationBuilder AddCommandLine(this IConfigurationBuilder builder, Action configureSource) + public static IConfigurationBuilder AddCommandLine(this IConfigurationBuilder builder, Action? configureSource) => builder.Add(configureSource); } } From fbfb3ba2b936588215b5ea45cdc50fd6cd861d8c Mon Sep 17 00:00:00 2001 From: Maksym Koshovyi Date: Fri, 19 Nov 2021 17:44:56 +0200 Subject: [PATCH 6/8] Add NetCoreAppMinimum to System.Runtime and System.Collections --- .../System.Collections/ref/System.Collections.csproj | 2 +- .../System.Collections/src/System.Collections.csproj | 4 ++-- src/libraries/System.Runtime/ref/System.Runtime.csproj | 2 +- src/libraries/System.Runtime/src/System.Runtime.csproj | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/libraries/System.Collections/ref/System.Collections.csproj b/src/libraries/System.Collections/ref/System.Collections.csproj index 9ab356c812196..7887ae4f8eac9 100644 --- a/src/libraries/System.Collections/ref/System.Collections.csproj +++ b/src/libraries/System.Collections/ref/System.Collections.csproj @@ -1,6 +1,6 @@ - $(NetCoreAppCurrent) + $(NetCoreAppCurrent);$(NetCoreAppMinimum) enable diff --git a/src/libraries/System.Collections/src/System.Collections.csproj b/src/libraries/System.Collections/src/System.Collections.csproj index 28dd9816dc245..e2f9f614c7dcf 100644 --- a/src/libraries/System.Collections/src/System.Collections.csproj +++ b/src/libraries/System.Collections/src/System.Collections.csproj @@ -1,8 +1,8 @@ - + true true - $(NetCoreAppCurrent) + $(NetCoreAppCurrent);$(NetCoreAppMinimum) enable diff --git a/src/libraries/System.Runtime/ref/System.Runtime.csproj b/src/libraries/System.Runtime/ref/System.Runtime.csproj index 9cbad9dddb804..10a9e2f04d50a 100644 --- a/src/libraries/System.Runtime/ref/System.Runtime.csproj +++ b/src/libraries/System.Runtime/ref/System.Runtime.csproj @@ -8,7 +8,7 @@ Remove warning disable when nullable attributes are respected, Type has no accessible constructors which use only CLS-compliant types --> $(NoWarn);0809;0618;CS8614;CS3015 - $(NetCoreAppCurrent) + $(NetCoreAppCurrent);$(NetCoreAppMinimum) enable diff --git a/src/libraries/System.Runtime/src/System.Runtime.csproj b/src/libraries/System.Runtime/src/System.Runtime.csproj index 8d726a1314792..b7efad65154c6 100644 --- a/src/libraries/System.Runtime/src/System.Runtime.csproj +++ b/src/libraries/System.Runtime/src/System.Runtime.csproj @@ -3,7 +3,7 @@ $(LibrariesProjectRoot)System.Runtime.Experimental\ref\System.Runtime.Experimental.csproj true - $(NetCoreAppCurrent) + $(NetCoreAppCurrent);$(NetCoreAppMinimum) enable True From 70c095af21a65f95c9e7b72454463ded9814d4ca Mon Sep 17 00:00:00 2001 From: Maksym Koshovyi Date: Fri, 19 Nov 2021 18:13:35 +0200 Subject: [PATCH 7/8] Revert "Add NetCoreAppMinimum to System.Runtime and System.Collections" This reverts commit fbfb3ba2b936588215b5ea45cdc50fd6cd861d8c. --- .../System.Collections/ref/System.Collections.csproj | 2 +- .../System.Collections/src/System.Collections.csproj | 4 ++-- src/libraries/System.Runtime/ref/System.Runtime.csproj | 2 +- src/libraries/System.Runtime/src/System.Runtime.csproj | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/libraries/System.Collections/ref/System.Collections.csproj b/src/libraries/System.Collections/ref/System.Collections.csproj index 7887ae4f8eac9..9ab356c812196 100644 --- a/src/libraries/System.Collections/ref/System.Collections.csproj +++ b/src/libraries/System.Collections/ref/System.Collections.csproj @@ -1,6 +1,6 @@ - $(NetCoreAppCurrent);$(NetCoreAppMinimum) + $(NetCoreAppCurrent) enable diff --git a/src/libraries/System.Collections/src/System.Collections.csproj b/src/libraries/System.Collections/src/System.Collections.csproj index e2f9f614c7dcf..28dd9816dc245 100644 --- a/src/libraries/System.Collections/src/System.Collections.csproj +++ b/src/libraries/System.Collections/src/System.Collections.csproj @@ -1,8 +1,8 @@ - + true true - $(NetCoreAppCurrent);$(NetCoreAppMinimum) + $(NetCoreAppCurrent) enable diff --git a/src/libraries/System.Runtime/ref/System.Runtime.csproj b/src/libraries/System.Runtime/ref/System.Runtime.csproj index 10a9e2f04d50a..9cbad9dddb804 100644 --- a/src/libraries/System.Runtime/ref/System.Runtime.csproj +++ b/src/libraries/System.Runtime/ref/System.Runtime.csproj @@ -8,7 +8,7 @@ Remove warning disable when nullable attributes are respected, Type has no accessible constructors which use only CLS-compliant types --> $(NoWarn);0809;0618;CS8614;CS3015 - $(NetCoreAppCurrent);$(NetCoreAppMinimum) + $(NetCoreAppCurrent) enable diff --git a/src/libraries/System.Runtime/src/System.Runtime.csproj b/src/libraries/System.Runtime/src/System.Runtime.csproj index b7efad65154c6..8d726a1314792 100644 --- a/src/libraries/System.Runtime/src/System.Runtime.csproj +++ b/src/libraries/System.Runtime/src/System.Runtime.csproj @@ -3,7 +3,7 @@ $(LibrariesProjectRoot)System.Runtime.Experimental\ref\System.Runtime.Experimental.csproj true - $(NetCoreAppCurrent);$(NetCoreAppMinimum) + $(NetCoreAppCurrent) enable True From 99dae39fc7d0e68713f4056374209270de2c6d36 Mon Sep 17 00:00:00 2001 From: Eric Erhardt Date: Fri, 19 Nov 2021 12:03:31 -0600 Subject: [PATCH 8/8] Fix NetCoreAppMinimum build --- ...Microsoft.Extensions.Configuration.CommandLine.csproj | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj index 8c01e0006ecf3..5be8641b37613 100644 --- a/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj +++ b/src/libraries/Microsoft.Extensions.Configuration.CommandLine/ref/Microsoft.Extensions.Configuration.CommandLine.csproj @@ -3,13 +3,18 @@ $(NetCoreAppCurrent);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum) enable + - - + + + + + +