From 227425a16323260162cb097a5c00ac01c1d470e7 Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Sun, 15 Aug 2021 19:54:43 -0500 Subject: [PATCH 1/5] Disable ReflectionCachesUpdateHandler_CachesCleared with aggressive trimming --- eng/testing/tests.mobile.targets | 2 +- .../tests/ReflectionCachesUpdateHandlerTests.cs | 1 + src/libraries/tests.proj | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index 0cb9a22a4b6cd..9a02369755eae 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -14,7 +14,7 @@ true - $(NoWarn);IL2111 + $(NoWarn);IL2111;IL2105 false diff --git a/src/libraries/System.ComponentModel.TypeConverter/tests/ReflectionCachesUpdateHandlerTests.cs b/src/libraries/System.ComponentModel.TypeConverter/tests/ReflectionCachesUpdateHandlerTests.cs index 905a580b72a96..84a7069bed6e3 100644 --- a/src/libraries/System.ComponentModel.TypeConverter/tests/ReflectionCachesUpdateHandlerTests.cs +++ b/src/libraries/System.ComponentModel.TypeConverter/tests/ReflectionCachesUpdateHandlerTests.cs @@ -11,6 +11,7 @@ namespace System.ComponentModel.Tests public class ReflectionCachesUpdateHandlerTests { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57456", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public void ReflectionCachesUpdateHandler_CachesCleared() { AttributeCollection ac1 = TypeDescriptor.GetAttributes(typeof(ReflectionCachesUpdateHandlerTests)); diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 5e8f9b5cf4ff4..d72c4d8a9cc17 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -252,7 +252,6 @@ - From d6f0d803f18bd0047d4ad4c27a02665c9ad22037 Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Sun, 15 Aug 2021 20:09:04 -0500 Subject: [PATCH 2/5] Enable more tests stopped by 2105 --- src/libraries/tests.proj | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index d72c4d8a9cc17..fdfeb815fab74 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -249,10 +249,6 @@ - - - - From 3572e71a1e061154b607fd91a1975558341cc6ed Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Sun, 15 Aug 2021 21:42:18 -0500 Subject: [PATCH 3/5] Create tests.mobile.targets Suppress IL2025 --- eng/testing/tests.mobile.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index 9a02369755eae..aa71f78154feb 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -14,7 +14,7 @@ true - $(NoWarn);IL2111;IL2105 + $(NoWarn);IL2111;IL2105;IL2025 false From 974c0c39c8980a2cb0f9c748144173cb9e721427 Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Mon, 16 Aug 2021 13:58:47 -0500 Subject: [PATCH 4/5] Remove comment enabling trim warnings --- eng/testing/tests.mobile.targets | 1 - 1 file changed, 1 deletion(-) diff --git a/eng/testing/tests.mobile.targets b/eng/testing/tests.mobile.targets index aa71f78154feb..fc196e0053efb 100644 --- a/eng/testing/tests.mobile.targets +++ b/eng/testing/tests.mobile.targets @@ -13,7 +13,6 @@ true true - $(NoWarn);IL2111;IL2105;IL2025 false From 4de8c0c7f85dd6bf2ecc817352cb5c7fcf4f3792 Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Tue, 17 Aug 2021 13:16:28 -0500 Subject: [PATCH 5/5] Mark more active issues --- .../ObservableCollection_ConstructorAndPropertyTests.cs | 2 ++ .../ObservableCollection/ObservableCollection_Serialization.cs | 1 + .../tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs | 3 +++ .../ReadOnlyObservableCollectionTests.cs | 2 ++ 4 files changed, 8 insertions(+) diff --git a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_ConstructorAndPropertyTests.cs b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_ConstructorAndPropertyTests.cs index cd8a7be947b74..c8a1e0acd756e 100644 --- a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_ConstructorAndPropertyTests.cs +++ b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_ConstructorAndPropertyTests.cs @@ -118,6 +118,7 @@ public static void IsReadOnlyTest() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttributeTests() { ObservableCollection col = new ObservableCollection(new[] {1, 2, 3, 4}); @@ -129,6 +130,7 @@ public static void DebuggerAttributeTests() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttribute_NullCollection_ThrowsArgumentNullException() { TargetInvocationException ex = Assert.Throws(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ObservableCollection), null)); diff --git a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_Serialization.cs b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_Serialization.cs index 65d5694a93a8f..ad46a712462f3 100644 --- a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_Serialization.cs +++ b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_Serialization.cs @@ -27,6 +27,7 @@ public void SerializeDeserialize_Roundtrips(ObservableCollection c) } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public void OnDeserialized_MonitorNotInitialized_ExpectSuccess() { var observableCollection = new ObservableCollection(); diff --git a/src/libraries/System.ObjectModel/tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs b/src/libraries/System.ObjectModel/tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs index 0b7e426898acd..dc30790225434 100644 --- a/src/libraries/System.ObjectModel/tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs +++ b/src/libraries/System.ObjectModel/tests/ReadOnlyDictionary/ReadOnlyDictionaryTests.cs @@ -224,6 +224,7 @@ public static void CannotModifyDictionaryTests_Negative() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttributeTests() { ReadOnlyDictionary dict = new ReadOnlyDictionary(new Dictionary{{1, 2}, {2, 4}, {3, 6}}); @@ -247,6 +248,7 @@ public static void DebuggerAttributeTests() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttribute_NullDictionary_ThrowsArgumentNullException() { TargetInvocationException ex = Assert.Throws(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyDictionary), null)); @@ -255,6 +257,7 @@ public static void DebuggerAttribute_NullDictionary_ThrowsArgumentNullException( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttribute_NullDictionaryKeys_ThrowsArgumentNullException() { TargetInvocationException ex = Assert.Throws(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyDictionary.KeyCollection), new Type[] { typeof(int) }, null)); diff --git a/src/libraries/System.ObjectModel/tests/ReadOnlyObservableCollection/ReadOnlyObservableCollectionTests.cs b/src/libraries/System.ObjectModel/tests/ReadOnlyObservableCollection/ReadOnlyObservableCollectionTests.cs index 6cc4f2cfe008f..981caa7eea9b1 100644 --- a/src/libraries/System.ObjectModel/tests/ReadOnlyObservableCollection/ReadOnlyObservableCollectionTests.cs +++ b/src/libraries/System.ObjectModel/tests/ReadOnlyObservableCollection/ReadOnlyObservableCollectionTests.cs @@ -197,6 +197,7 @@ public static void CannotModifyDictionaryTests_Negative() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttribute_Tests() { ReadOnlyObservableCollection col = new ReadOnlyObservableCollection(new ObservableCollection(new[] {1, 2, 3, 4})); @@ -208,6 +209,7 @@ public static void DebuggerAttribute_Tests() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/57588", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] public static void DebuggerAttribute_NullCollection_ThrowsArgumentNullException() { TargetInvocationException ex = Assert.Throws(() => DebuggerAttributes.ValidateDebuggerTypeProxyProperties(typeof(ReadOnlyObservableCollection), null));