-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI matrix update: add Ubuntu 21.04 - second attempt #60162
Conversation
Same comment as in your other PR:
|
As it stands now - it would only run in a rolling build |
I believe there is an open question from reviewers above which requires attention:
@aik-jahoda Can you share the results of the rolling build which tests your changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. @safern do you agree?
Actually, I'm not entirely certain how to interpret all these failures in the other legs. I see the linked log shows at least one pass on the new queues. Do you understand the other failures? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
The original CI matrix change was reverted (#60040) because of a failing CI.
part of #57947
original PR: #59578