[release/6.0] Fix: CTS.TryReset() concurrency issue #60182 #60323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @mangod9 Issue DetailsBackport of #60224 to release/6.0 /cc @stephentoub @sakno Customer ImpactTestingRisk
|
danmoseley
approved these changes
Oct 13, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60224 to release/6.0
Fixes #60182
/cc @stephentoub @sakno
Customer Impact
The new CancellationTokenSource.TryReset method can, in rare race conditions, throw an ObjectDisposedException as part of normal usage. It occurs because the underlying TimerQueueTimer being used for coordination gets closed upon the timer callback firing, TryReset tries to Change that timer, and Change throws an ObjectDisposedException due to the timer having been closed. The simple short-term fix is to simply eat the benign exception in TryReset. We have various options for longer-term fixes in main.
Testing
CI
Risk
Minimal. The change simply adds a try/catch block to eat a specific exception type.