From 888694a74a5744f3d2acea90cb29cc6f7404cfa7 Mon Sep 17 00:00:00 2001 From: Simon Rozsival Date: Thu, 18 Nov 2021 11:09:50 +0100 Subject: [PATCH] Revert "[Mono] Skip flaky android tests (#61460)" This reverts commit 8ad84e88d86fb7845187ae0aa17be48ed1a46c97. --- .../tests/FunctionalTests/UnixPingUtilityTests.cs | 1 - .../System.Net.Sockets/tests/FunctionalTests/SendTo.cs | 2 -- .../tests/FunctionalTests/SocketOptionNameTest.cs | 2 -- .../System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs | 4 ---- 4 files changed, 9 deletions(-) diff --git a/src/libraries/System.Net.Ping/tests/FunctionalTests/UnixPingUtilityTests.cs b/src/libraries/System.Net.Ping/tests/FunctionalTests/UnixPingUtilityTests.cs index b16401f2b5e2c..b34f45bdd881f 100644 --- a/src/libraries/System.Net.Ping/tests/FunctionalTests/UnixPingUtilityTests.cs +++ b/src/libraries/System.Net.Ping/tests/FunctionalTests/UnixPingUtilityTests.cs @@ -26,7 +26,6 @@ public class UnixPingUtilityTests [InlineData(1000)] [InlineData(1500)] [PlatformSpecific(TestPlatforms.AnyUnix)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public static void TimeoutIsRespected(int timeout) { Process p = ConstructPingProcess(IPAddress.Parse(TestSettings.UnreachableAddress), 50, timeout); diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendTo.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendTo.cs index 433846482c858..70205f8033cc4 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendTo.cs +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendTo.cs @@ -64,7 +64,6 @@ public async Task NullEndpoint_Throws_ArgumentException() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public async Task Datagram_UDP_ShouldImplicitlyBindLocalEndpoint() { using var socket = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp); @@ -85,7 +84,6 @@ public async Task Datagram_UDP_ShouldImplicitlyBindLocalEndpoint() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public async Task Datagram_UDP_AccessDenied_Throws_DoesNotBind() { IPEndPoint invalidEndpoint = new IPEndPoint(IPAddress.Broadcast, 1234); diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs index 5879de156120c..5073f60c3e6a1 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs @@ -51,7 +51,6 @@ public void ReuseUnicastPort_CreateSocketSetOption() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public void MulticastOption_CreateSocketSetGetOption_GroupAndInterfaceIndex_SetSucceeds_GetThrows() { int interfaceIndex = 0; @@ -66,7 +65,6 @@ public void MulticastOption_CreateSocketSetGetOption_GroupAndInterfaceIndex_SetS } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoNorServerCore))] // Skip on Nano: https://github.com/dotnet/runtime/issues/26286 - [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public async Task MulticastInterface_Set_AnyInterface_Succeeds() { // On all platforms, index 0 means "any interface" diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs index cc16a77f1997d..66f69e1ce70da 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs @@ -439,7 +439,6 @@ public void Connect_InvalidArguments_Throws() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public async Task ConnectAsync_StringHost_Success() { using (var c = new UdpClient()) @@ -449,7 +448,6 @@ public async Task ConnectAsync_StringHost_Success() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public async Task ConnectAsync_IPAddressHost_Success() { using (var c = new UdpClient()) @@ -459,7 +457,6 @@ public async Task ConnectAsync_IPAddressHost_Success() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public void Connect_StringHost_Success() { using (var c = new UdpClient()) @@ -469,7 +466,6 @@ public void Connect_StringHost_Success() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)] public void Connect_IPAddressHost_Success() { using (var c = new UdpClient())