[release/6.0] Handle when DestroyStructure API passes null to the IL marshaller #62002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… valuetypes. This is an issue with field marshallers of nested non-blittable types.
AaronRobinsonMSFT
added
the
Servicing-consider
jkoritzinsky
approved these changes
Nov 24, 2021
davidwrighton
approved these changes
Nov 29, 2021
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #61985 to release/6.0
/cc @AaronRobinsonMSFT
Customer Impact
The issue was reported by a customer. This seems to be additional fallout from the field marshaling work done in early .NET 5. This is a regression in behavior from .NET Framework. The scenario is likely not common given the code has been broken since early .NET 5. The fix will impact all non-blittable field marshaling due to the current architecture. There is a workaround if the types can be changed, but otherwise there is no mitigation.
See #61839
Testing
Additional testing for the targeted scenario was added.
Risk
Medium. The struct field marshaling code paths have proven to be very dangerous to alter. In this case, since the bug would always result in crashing behavior it is lower than High, but does still introduce some risk. The most obvious risk here would be for products that have not tried to port from .NET Framework yet.