Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsKnownConstant jit helper and optimize 'str == ""' with str.StartsWith('c') #63734

Merged
merged 26 commits into from
Jan 19, 2022
Merged

Add IsKnownConstant jit helper and optimize 'str == ""' with str.StartsWith('c') #63734

merged 26 commits into from
Jan 19, 2022

Commits on Jan 12, 2022

  1. Don't reuse args in EnC

    @EgorBo
    EgorBo committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    9f55fa6 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Merge branch 'main' of https://github.com/dotnet/runtime into fix-enc… 

    …-case
    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    7d3ef94 View commit details
    Browse the repository at this point in the history

  2. Introduce RuntimeHelpers.IsKnownConstant and use for 'str == ""'

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    0a717aa View commit details
    Browse the repository at this point in the history

  3. Remove unrelated change, add gtFoldExpr

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    407a953 View commit details
    Browse the repository at this point in the history

  4. Also, optimize String.StartsWith

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    9d45461 View commit details
    Browse the repository at this point in the history

  5. Update comment

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    2f8a034 View commit details
    Browse the repository at this point in the history

  6. Update src/libraries/System.Private.CoreLib/src/System/String.Compari… 

    …son.cs

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
    @EgorBo @MihaZupan
    EgorBo and MihaZupan authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    4883a46 View commit details
    Browse the repository at this point in the history

  7. Delay expansion to morph, replace generic signature with overloads

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    aa88cf9 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'jit-isknownconstant' of https://github.com/EgorBo/runti… 

    …me-1 into jit-isknownconstant
    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    64843f0 View commit details
    Browse the repository at this point in the history

  9. Make string overload nullable

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    2ebdae9 View commit details
    Browse the repository at this point in the history

  10. Use GTF_ALL_EFFECT

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    e264d27 View commit details
    Browse the repository at this point in the history

  11. Address feedback

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    f08a182 View commit details
    Browse the repository at this point in the history

  12. fix copy-paste

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    8e5fd0d View commit details
    Browse the repository at this point in the history

  13. Update src/coreclr/jit/compiler.hpp 

    Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
    @EgorBo @SingleAccretion
    EgorBo and SingleAccretion authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    e2ebf30 View commit details
    Browse the repository at this point in the history

  14. Update src/coreclr/jit/compiler.hpp 

    Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
    @EgorBo @SingleAccretion
    EgorBo and SingleAccretion authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    895abc4 View commit details
    Browse the repository at this point in the history

  15. Address feedback

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    45bfe7c View commit details
    Browse the repository at this point in the history

  16. Remove [MethodImpl(MethodImplOptions.AggressiveInlining)], handle it … 

    …in the inliner
    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    80f9ddd View commit details
    Browse the repository at this point in the history

  17. clean up

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    eebd8d1 View commit details
    Browse the repository at this point in the history

  18. Only boost for constant-arg cases

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    e0e3e51 View commit details
    Browse the repository at this point in the history

  19. Remove redundant opts.OptimizationEnabled()s

    @EgorBo
    EgorBo committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    5b2fbfe View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Update importer.cpp

    @EgorBo
    EgorBo authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    30e1855 View commit details
    Browse the repository at this point in the history

  2. Update String.Comparison.cs

    @EgorBo
    EgorBo authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    3cb8402 View commit details
    Browse the repository at this point in the history

  3. Update String.Comparison.cs

    @EgorBo
    EgorBo authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    7c7c264 View commit details
    Browse the repository at this point in the history

  4. Add tests

    @EgorBo
    EgorBo committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    a9b85fc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'jit-isknownconstant' of https://github.com/EgorBo/runti… 

    …me-1 into jit-isknownconstant
    @EgorBo
    EgorBo committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    a3e5f3c View commit details
    Browse the repository at this point in the history

  6. Fix unrelated invalid IR, we should not import TYP_USHORT constant

    @EgorBo
    EgorBo committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    4947947 View commit details
    Browse the repository at this point in the history