-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Allow missing assemblies in llvmonly+interp mode. #64294
Conversation
Part of the fix for dotnet#51961.
A downside of this is that it would also ignore issues when there is a mismatch between assemblies and AOT images. |
Do we want a different approach without that downside? A way to encode a permitted list of missing assemblies, as opposed to just being more chill about them in general? |
Can we raise the log level from these two trace calls to a warning? runtime/src/mono/mono/mini/aot-runtime.c Lines 327 to 337 in 33940e6
|
An alternative would be to emit the aot image, but don't actually emit any code in it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this for now, if there are objections lets discuss them.
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Part of the fix for #51961.