remove support for Ssl2 #64322
remove support for Ssl2 #64322
Conversation
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue Detailsfixes #35942 we may add test to verify we throw something reasonable if only
|
|
|
||
| if (_lastFrame.Header.Length < 0) | ||
| { | ||
| if (NetEventSource.Log.IsEnabled()) NetEventSource.Error(this, "invalid TLS frame size"); | ||
| throw new IOException(SR.net_frame_read_size); | ||
| throw new AuthenticationException(SR.net_frame_read_size); |
There was a problem hiding this comment.
Why to change this exception when you leave IOException in GetFrameSize?
In other words: What is the rule to throw IOException vs. AuthenticationException?
There was a problem hiding this comment.
ServerAsyncAuthenticate_InvalidHello_Throws checks for the exception type. In the past we can get one or the other depending on connection management. So I had to choose. Since getting invalid length did not feel like IO problem, I decided to use AuthenticationException
|
failing cryptography test is #64389 |
ghost
locked as resolved and limited conversation to collaborators
fixes #35942
we may add test to verify we throw something reasonable if only
SslProtocols.Ssl2is requested but I'm not sure if it is worth of the effort.