-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] pass ExitStatus when calling quit_ #64734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
WebAssembly architecture
area-System.Runtime.InteropServices.JavaScript
labels
Feb 3, 2022
ghost
assigned pavelsavara
Feb 3, 2022
fix logging
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
radekdoulik
approved these changes
Feb 3, 2022
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
|
There's also:
in this log. |
In case it helps - I had found that
As a fix I changed |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For explanation Posix
exit
is implemented in emscripten asprocess.exit
and stop immediately.ExitStatus
exception. That exception need to bubble thru all the call stack out intouncaughtException
handler, which will recognize the class and swallow it. I think that going thru all the catch/finally statements it why it's designed this way. Also onV8 it's probably the only way how to stop, but I'm not sure now.There is also
noExitRuntime
setting which could prevent that. We have it true on browser and I just set it to false on node and v8 in this PR.Fixes #64727