Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Fix scenario specific tests #64800

Merged
merged 5 commits into from
Feb 5, 2022

Conversation

maraf
Copy link
Member

@maraf maraf commented Feb 4, 2022

@maraf maraf added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Feb 4, 2022
@maraf maraf requested a review from pavelsavara February 4, 2022 09:51
@ghost ghost assigned maraf Feb 4, 2022
@ghost
Copy link

ghost commented Feb 4, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: maraf
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: -

@maraf
Copy link
Member Author

maraf commented Feb 4, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member

fail: Failed to find the middleware assembly at /datadisks/disk1/work/A60E08AE/p/xharness/RemoteLoopMiddleware/RemoteLoopServer.dll
Log

@premun
Copy link
Member

premun commented Feb 4, 2022

FWIW this setting is now true by default (dotnet/arcade#8216):

<EnableXHarnessTelemetry>true</EnableXHarnessTelemetry>

And as such can be omitted.

@maraf
Copy link
Member Author

maraf commented Feb 4, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Feb 4, 2022

Add wasmtestonnodejs at https://github.com/dotnet/runtime/blob/main/eng/pipelines/runtime-extra-platforms.yml#L197 to run the library tests with node. I have #64766 open to add it for main.

@maraf
Copy link
Member Author

maraf commented Feb 4, 2022

Add wasmtestonnodejs at https://github.com/dotnet/runtime/blob/main/eng/pipelines/runtime-extra-platforms.yml#L197 to run the library tests with node

I'm trying to fix wasm on browser here. It seems that the path where RemoteLoopMiddleware gets compiled has changed and so it doesn't get included as correlation payload.

@radical
Copy link
Member

radical commented Feb 4, 2022

I merged my PR to enable library tests on nodejs, fyi.

@maraf
Copy link
Member Author

maraf commented Feb 4, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf maraf merged commit 5906521 into dotnet:main Feb 5, 2022
@maraf maraf deleted the WasmFixScenarioSpecificTests branch February 5, 2022 09:44
@ghost ghost locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants