-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move 20H2 queues to server 2022 #64827
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Does IsIcuCompatiblePlatform
need to be updated?
runtime/src/libraries/System.Globalization/tests/IcuTests.cs
Lines 12 to 13 in 59e643b
private static bool IsIcuCompatiblePlatform => PlatformDetection.IsNotWindows || | |
PlatformDetection.IsWindows10Version1903OrGreater; |
I'm waiting for confirmation from the Windows team that this is indeed expected (the missing files on wow64), if they confirm that, we need to update that condition to detect if we are in server core and x86. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsFixes: #64763 The 20H2 queues are Server Core, and Server Core doesn't contain icu.dll on the SysWOW64 directory, so the tests that expect ICU to be loaded on SKUs newer or equal to 1903 fail when running on x86. Since we already have coverage for Server Core on the docker images, move to the next Data Center LTS release which is Server 2022. FYI: @tarekgh
|
Libraries test run on windows are now green. Will merge to unblock other PRs. |
Fix one more instance not covered by dotnet#64827. This should fix the same failure in runtime-extra-platforms.
* Move one more 20H2 queue to server 2022 Fix one more instance not covered by #64827. This should fix the same failure in runtime-extra-platforms. * Update IsIcuCompatiblePlatform
Fixes: #64763
The 20H2 queues are Server Core, and Server Core doesn't contain icu.dll on the SysWOW64 directory, so the tests that expect ICU to be loaded on SKUs newer or equal to 1903 fail when running on x86.
Since we already have coverage for Server Core on the docker images, move to the next Data Center LTS release which is Server 2022.
FYI: @tarekgh