Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 20H2 queues to server 2022 #64827

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Conversation

safern
Copy link
Member

@safern safern commented Feb 4, 2022

Fixes: #64763

The 20H2 queues are Server Core, and Server Core doesn't contain icu.dll on the SysWOW64 directory, so the tests that expect ICU to be loaded on SKUs newer or equal to 1903 fail when running on x86.

Since we already have coverage for Server Core on the docker images, move to the next Data Center LTS release which is Server 2022.

FYI: @tarekgh

@safern safern requested a review from a team February 4, 2022 20:06
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned safern Feb 4, 2022
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Does IsIcuCompatiblePlatform need to be updated?

private static bool IsIcuCompatiblePlatform => PlatformDetection.IsNotWindows ||
PlatformDetection.IsWindows10Version1903OrGreater;

@safern
Copy link
Member Author

safern commented Feb 4, 2022

Thanks! Does IsIcuCompatiblePlatform need to be updated?

I'm waiting for confirmation from the Windows team that this is indeed expected (the missing files on wow64), if they confirm that, we need to update that condition to detect if we are in server core and x86.

@ghost
Copy link

ghost commented Feb 4, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: #64763

The 20H2 queues are Server Core, and Server Core doesn't contain icu.dll on the SysWOW64 directory, so the tests that expect ICU to be loaded on SKUs newer or equal to 1903 fail when running on x86.

Since we already have coverage for Server Core on the docker images, move to the next Data Center LTS release which is Server 2022.

FYI: @tarekgh

Author: safern
Assignees: safern
Labels:

area-Infrastructure

Milestone: -

@safern
Copy link
Member Author

safern commented Feb 4, 2022

Libraries test run on windows are now green. Will merge to unblock other PRs.

@safern safern merged commit d43c048 into dotnet:main Feb 4, 2022
@safern safern deleted the updateServerQueues branch February 4, 2022 23:38
sbomer added a commit to sbomer/runtime that referenced this pull request Feb 7, 2022
Fix one more instance not covered by dotnet#64827.
This should fix the same failure in runtime-extra-platforms.
sbomer added a commit that referenced this pull request Feb 7, 2022
* Move one more 20H2 queue to server 2022

Fix one more instance not covered by #64827.
This should fix the same failure in runtime-extra-platforms.

* Update IsIcuCompatiblePlatform
@ghost ghost locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

system.globalization.tests.icutests.icushouldbeloaded
4 participants