Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Activity.HasRemoteParent #66489

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Mar 11, 2022

Fixes #65660

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Mar 11, 2022

Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #65660

Author: tarekgh
Assignees: -
Labels:

new-api-needs-documentation, area-System.Diagnostics.Activity

Milestone: -

@tarekgh tarekgh requested a review from noahfalk March 11, 2022 01:28
@tarekgh
Copy link
Member Author

tarekgh commented Mar 11, 2022

CC @reyang @cijothomas @noahfalk

…iagnostics/Activity.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great : )

@tarekgh tarekgh merged commit 4fc0856 into dotnet:main Mar 11, 2022
@tarekgh tarekgh deleted the AddActivity.HasRemoteParent branch March 11, 2022 22:05
@ghost ghost locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Activity.HasRemoteParent (and problematic docs for Activity.Parent)
3 participants