[wasm] Do not set _WasmDevel=true for blazor projects #66793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to workaround wasm-ld getting oomkilled. Fixes dotnet#66725, and dotnet#66591
lambdageek
approved these changes
Mar 21, 2022
akoeplinger
approved these changes
Mar 21, 2022
lewing
approved these changes
Mar 21, 2022
|
Since this PR has 3 approvals and it fixes #66725 (which blocks clean CI and from Test Monitor perspective is the most common reason for CI failures) I am going to merge it. |
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
* [wasm] Do not set _WasmDevel=true for blazor projects to workaround wasm-ld getting oomkilled. Fixes dotnet#66725, and dotnet#66591 * Fix test
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to workaround wasm-ld getting oomkilled.
Fixes #66725