Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional work for x86 support for NativeAOT #68130

Closed
wants to merge 1 commit into from
Closed

Additional work for x86 support for NativeAOT #68130

wants to merge 1 commit into from

Conversation

kant2002
Copy link
Contributor

Related to #86573

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 17, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 17, 2022
@ghost
Copy link

ghost commented Apr 17, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #86573

Author: kant2002
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

jkotas
jkotas reviewed Apr 17, 2022
View reviewed changes
src/coreclr/jit/fgopt.cpp
@@ -1834,7 +1834,7 @@ bool Compiler::fgCanCompactBlocks(BasicBlock* block, BasicBlock* bNext)
return false;
}

#if defined(TARGET_ARM)
#if defined(FEATURE_EH_FUNCLETS) && defined(TARGET_ARM)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this trying to achieve? FEATURE_EH_FUNCLETS is always enabled for ARM, so this change is no-op.

jkotas
jkotas reviewed Apr 17, 2022
View reviewed changes
src/coreclr/inc/eetwain.h
@@ -31,9 +31,7 @@
#include "bitvector.h"
#include "gcinfotypes.h"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work for regular CoreCLR. Switching regular CoreCLR to use USE_GC_INFO_DECODER would be a ton more work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please forgive my ignorance. My pattern matching sometimes works like monkey typing on typewriter. I not fully understand boundaries, so I occasionally overstep. Do not want to do more work then necessary.

@runfoapp runfoapp bot mentioned this pull request Apr 20, 2022
Closed
@JulieLeeMSFT JulieLeeMSFT added the needs-author-action An issue or pull request that requires more info or actions from the author. label May 16, 2022
@JulieLeeMSFT
Copy link
Member

@kant2002 could you please address Jan's comment in order to move forward? Thanks.
"This won't work for regular CoreCLR. Switching regular CoreCLR to use USE_GC_INFO_DECODER would be a ton more work."

@JulieLeeMSFT JulieLeeMSFT added area-NativeAOT-coreclr and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jun 6, 2022
@JulieLeeMSFT
Copy link
Member

Moved to @agocke per offline discussion.

@ghost ghost added the no-recent-activity label Jun 20, 2022
@ghost
Copy link

ghost commented Jun 20, 2022

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost
Copy link

ghost commented Jul 5, 2022

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@ghost ghost closed this Jul 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 4, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@agocke agocke

@kant2002 kant2002

Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kant2002 @JulieLeeMSFT @jkotas @agocke