diff --git a/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.KeyValuePair.cs b/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.KeyValuePair.cs index 76c2676c8f7ef..5d5be68091855 100644 --- a/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.KeyValuePair.cs +++ b/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.KeyValuePair.cs @@ -396,6 +396,7 @@ private class TrailingAngleBracketPolicy : JsonNamingPolicy [Theory] [InlineData(typeof(KeyNameNullPolicy), "Key")] [InlineData(typeof(ValueNameNullPolicy), "Value")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task InvalidPropertyNameFail(Type policyType, string offendingProperty) { var options = new JsonSerializerOptions diff --git a/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.AttributePresence.cs b/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.AttributePresence.cs index 11fbed0776d1c..a4f44686dc857 100644 --- a/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.AttributePresence.cs +++ b/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.AttributePresence.cs @@ -115,6 +115,7 @@ public async Task PublicParameterlessCtor_MultiplePublicParameterizedCtors_WithA #if !BUILDING_SOURCE_GENERATOR_TESTS // These are compile-time warnings from the source generator. [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task MultipleAttributes_NotSupported() { async Task RunTestAsync() diff --git a/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Exceptions.cs b/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Exceptions.cs index de47537732bf0..18b618127dc62 100644 --- a/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Exceptions.cs +++ b/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Exceptions.cs @@ -317,6 +317,7 @@ public async Task CaseInsensitiveFails() #if BUILDING_SOURCE_GENERATOR_TESTS [ActiveIssue("Multi-dim arrays not supported.")] #endif + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task ClassWithUnsupportedCollectionTypes() { Exception e; diff --git a/src/libraries/System.Text.Json/tests/Common/ExtensionDataTests.cs b/src/libraries/System.Text.Json/tests/Common/ExtensionDataTests.cs index d3a6548226d71..7f91c4d7236d8 100644 --- a/src/libraries/System.Text.Json/tests/Common/ExtensionDataTests.cs +++ b/src/libraries/System.Text.Json/tests/Common/ExtensionDataTests.cs @@ -324,6 +324,7 @@ public class ClassWithTwoExtensionProperties #if BUILDING_SOURCE_GENERATOR_TESTS [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")] #endif + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task InvalidExtensionPropertyFail() { // Baseline @@ -798,7 +799,7 @@ public async Task DeserializeIntoJsonObjectProperty() #if BUILDING_SOURCE_GENERATOR_TESTS [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")] #endif - + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task DeserializeIntoSystemObjectProperty() { string json = @"{""MyDict"":{""Property1"":1}}"; @@ -1088,6 +1089,7 @@ public class ClassWithInvalidExtensionPropertyStringJsonNode #if BUILDING_SOURCE_GENERATOR_TESTS [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")] #endif + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task ExtensionProperty_InvalidDictionary() { var obj1 = new ClassWithInvalidExtensionPropertyStringString(); @@ -1147,6 +1149,7 @@ public class ClassWithMultipleDictionaries #if BUILDING_SOURCE_GENERATOR_TESTS [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")] #endif + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task DeserializeIntoImmutableDictionaryProperty() { // baseline diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs b/src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs index 568357a5088b1..25463ad21c410 100644 --- a/src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs +++ b/src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs @@ -64,6 +64,7 @@ public async Task CustomNamePolicy() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task NullNamePolicy() { var options = new JsonSerializerOptions(); @@ -127,6 +128,7 @@ public async Task JsonPropertyNameAttribute() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task JsonNameAttributeDuplicateDesignTimeFail() { { @@ -141,6 +143,7 @@ public async Task JsonNameAttributeDuplicateDesignTimeFail() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task JsonNameConflictOnCamelCasingFail() { { diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.NonPublicAccessors.cs b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.NonPublicAccessors.cs index b43f622dce0ae..70935daaf5c14 100644 --- a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.NonPublicAccessors.cs +++ b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.NonPublicAccessors.cs @@ -325,6 +325,7 @@ public class ClassWithMixedPropertyAccessors_PropertyAttributes [InlineData(typeof(ClassWithPrivate_InitOnlyProperty_WithJsonIncludeProperty))] [InlineData(typeof(ClassWithInternal_InitOnlyProperty_WithJsonIncludeProperty))] [InlineData(typeof(ClassWithProtected_InitOnlyProperty_WithJsonIncludeProperty))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public virtual async Task NonPublicProperty_WithJsonInclude_Invalid(Type type) { InvalidOperationException ex = await Assert.ThrowsAsync(async () => await Serializer.DeserializeWrapper("{}", type)); diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs index 85a4f81ddfe16..66ee85118fcb1 100644 --- a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs +++ b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs @@ -339,6 +339,7 @@ public async Task Ignore_PublicProperty_ConflictWithPublicDuePolicy() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDueAttributes() { // Serialize @@ -353,6 +354,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDueAttributes() { // Serialize @@ -367,6 +369,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDueAttributes_SingleInheritance() { // Serialize @@ -390,6 +393,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDueAttributes_SingleInheritance() { // Serialize @@ -413,6 +417,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDueAttributes_DoubleInheritance() { // Serialize @@ -437,6 +442,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDueAttributes_DoubleInheritance() { // Serialize @@ -461,6 +467,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDuePolicy() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -477,6 +484,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDuePolicy() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -493,6 +501,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDuePolicy_SingleInheritance() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -519,6 +528,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDuePolicy_SingleInheritance() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -545,6 +555,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicProperty_ConflictDuePolicy_DobuleInheritance() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -572,6 +583,7 @@ await Assert.ThrowsAsync( } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task Throw_PublicPropertyAndField_ConflictDuePolicy_DobuleInheritance() { var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase }; @@ -1138,6 +1150,7 @@ public async Task JsonIgnoreAttribute() // Needs support for more collections. [ActiveIssue("https://github.com/dotnet/runtime/issues/53393")] #endif + [ActiveIssue("https://github.com/dotnet/runtime/issues/71981")] public async Task JsonIgnoreAttribute_UnsupportedCollection() { string json = @@ -1178,7 +1191,7 @@ public async Task JsonIgnoreAttribute_UnsupportedCollection() var dictionary = new Dictionary(); // Uri is an unsupported dictionary key. - dictionary.Add(new Uri("http://foo"), "bar"); + dictionary.Add(new Uri("http://typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]"), "bar"); var concurrentDictionary = new ConcurrentDictionary(dictionary); @@ -2413,6 +2426,7 @@ public class ClassWithThingsToIgnore_PerProperty [Theory] [InlineData(typeof(ClassWithBadIgnoreAttribute))] [InlineData(typeof(StructWithBadIgnoreAttribute))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail(Type type) { InvalidOperationException ex = await Assert.ThrowsAsync(async () => await Serializer.DeserializeWrapper("{}", type)); @@ -2433,6 +2447,7 @@ public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail(T [Theory] [InlineData(typeof(ClassWithBadIgnoreAttribute))] [InlineData(typeof(StructWithBadIgnoreAttribute))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(Type type) { InvalidOperationException ex = await Assert.ThrowsAsync(async () => await Serializer.DeserializeWrapper("", type)); @@ -2745,6 +2760,7 @@ public async Task JsonIgnoreCondition_Polymorphic() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task SerializationMetadataNotComputedWhenMemberIgnored() { string janePayload = @"{""Name"":""Jane Doe""}"; diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs index 5a0861ef7f187..2845373272ac7 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs @@ -300,6 +300,7 @@ public PropertyVisibilityTests_Default() [InlineData(typeof(ClassWithPrivate_InitOnlyProperty_WithJsonIncludeProperty))] [InlineData(typeof(ClassWithInternal_InitOnlyProperty_WithJsonIncludeProperty))] [InlineData(typeof(ClassWithProtected_InitOnlyProperty_WithJsonIncludeProperty))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public override async Task NonPublicProperty_WithJsonInclude_Invalid(Type type) { // Exception messages direct users to use JsonSourceGenerationMode.Metadata to see a more detailed error. diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs index 88e371435571f..13da7fd8d9590 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs @@ -58,6 +58,7 @@ public void DeserializeInvalidType(Type type) [Theory] [MemberData(nameof(TypesWithInvalidMembers_WithMembers))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task TypeWithInvalidMember(Type classType, Type invalidMemberType, string invalidMemberName) { static void ValidateException(InvalidOperationException ex, Type classType, Type invalidMemberType, string invalidMemberName) diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PropertyNameTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PropertyNameTests.cs index 6da381d144dab..60dd6e27ac76a 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PropertyNameTests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PropertyNameTests.cs @@ -22,6 +22,7 @@ public async Task JsonNullNameAttribute() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))] public async Task JsonNameConflictOnCaseInsensitiveFail() { string json = @"{""myInt"":1,""MyInt"":2}"; diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index ed1e67f8d1c19..0ebc23f231a8d 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -28,7 +28,8 @@ - + + @@ -64,10 +65,18 @@ + + + + + + + + @@ -564,7 +573,7 @@ -