From b9d18e1a162176963bdf8c2fb2fcf4a55b61b638 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Thu, 4 Aug 2022 16:29:36 -0700 Subject: [PATCH 01/25] Clean up AOT publish process --- .../Microsoft.DotNet.ILCompiler.targets | 43 ++++++++++++------- 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets index d08cc8241da6a..5f19f52f223c5 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets @@ -1,5 +1,12 @@ + + + + true + + + @@ -26,7 +33,6 @@ $(OSHostArch) runtime.$(OSIdentifier)-$(IlcHostArch).Microsoft.DotNet.ILCompiler - true @@ -39,29 +45,34 @@ - - - - - - + + + + + + + + + + + + + + - - + @(ResolvedILCompilerPack->'%(PackageDirectory)') @(ResolvedILCompilerPack->'%(PackageDirectory)') >@(ResolvedILCompilerPack->'%(PackageDirectory)') - - - %(PackageDefinitions.ResolvedPath) - %(PackageDefinitions.ResolvedPath) - - - + From 62a302a2bdc76426e6ea9e533dbf29ffb7a830e6 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Fri, 5 Aug 2022 05:46:39 -0700 Subject: [PATCH 02/25] Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets Co-authored-by: Sven Boemer --- .../BuildIntegration/Microsoft.DotNet.ILCompiler.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets index 5f19f52f223c5..7d501e1ae8451 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets @@ -49,7 +49,7 @@ - + From b5f37f01f061d6b2f207fd6f6da1b3b7a0390078 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Fri, 5 Aug 2022 05:46:51 -0700 Subject: [PATCH 03/25] Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets Co-authored-by: Sven Boemer --- .../BuildIntegration/Microsoft.DotNet.ILCompiler.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets index 7d501e1ae8451..0d7572fd2bb2d 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets @@ -56,7 +56,7 @@ From e992c9bb86f6fbc9abb4bed4c5cce6cede733d93 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Sun, 7 Aug 2022 10:41:12 -0700 Subject: [PATCH 04/25] FB and working around running native aot tests --- eng/testing/tests.singlefile.targets | 2 +- .../BuildFrameworkNativeObjects.proj | 2 +- ...oft.DotNet.ILCompiler.SingleEntry.targets} | 27 +++++++++---------- .../Microsoft.DotNet.ILCompiler.props | 3 +-- 4 files changed, 15 insertions(+), 19 deletions(-) rename src/coreclr/nativeaot/BuildIntegration/{Microsoft.DotNet.ILCompiler.targets => Microsoft.DotNet.ILCompiler.SingleEntry.targets} (80%) diff --git a/eng/testing/tests.singlefile.targets b/eng/testing/tests.singlefile.targets index 1cfa4ba1cdeca..e4a246d6ef1c0 100644 --- a/eng/testing/tests.singlefile.targets +++ b/eng/testing/tests.singlefile.targets @@ -34,7 +34,7 @@ true - + diff --git a/src/coreclr/nativeaot/BuildIntegration/BuildFrameworkNativeObjects.proj b/src/coreclr/nativeaot/BuildIntegration/BuildFrameworkNativeObjects.proj index 6469964c0170a..d3ef3ec15cdbb 100644 --- a/src/coreclr/nativeaot/BuildIntegration/BuildFrameworkNativeObjects.proj +++ b/src/coreclr/nativeaot/BuildIntegration/BuildFrameworkNativeObjects.proj @@ -10,7 +10,7 @@ true - + - true - - win osx @@ -33,36 +30,36 @@ $(OSHostArch) runtime.$(OSIdentifier)-$(IlcHostArch).Microsoft.DotNet.ILCompiler - + + true - RunResolvePackageDependencies ImportRuntimeIlcPackageTarget SetupProperties - - - + + - + + TargetFramework="@(OldKnownILCompilerPack ->'%(TargetFramework)')" + ILCompilerPackNamePattern="@(OldKnownILCompilerPack ->'%(ILCompilerPackNamePattern)')" + ILCompilerPackVersion="@(ILCompilerRefernece->'%(Version)')" + ILCompilerRuntimeIdentifiers="@(OldKnownILCompilerPack ->'%(ILCompilerRuntimeIdentifiers)')" + Condition="@(ILCompilerReference->'%(Version)')!=''"/> - + @@ -73,6 +70,6 @@ - + diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props index e883245ee0f7c..c2f2f45bce605 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props @@ -10,10 +10,9 @@ Copyright (c) .NET Foundation. All rights reserved. *********************************************************************************************** --> - - $(MSBuildThisFileDirectory)Microsoft.DotNet.ILCompiler.targets + $(MSBuildThisFileDirectory)Microsoft.DotNet.ILCompiler.SingleEntry.targets From dcf710cbefb0c059edd1c21ba10c53456db8f267 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Mon, 8 Aug 2022 03:58:53 -0700 Subject: [PATCH 05/25] update crossgen2 reference --- src/coreclr/tools/aot/crossgen2/crossgen2.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/tools/aot/crossgen2/crossgen2.csproj b/src/coreclr/tools/aot/crossgen2/crossgen2.csproj index 42f192a3f123f..8696352abc03e 100644 --- a/src/coreclr/tools/aot/crossgen2/crossgen2.csproj +++ b/src/coreclr/tools/aot/crossgen2/crossgen2.csproj @@ -42,7 +42,7 @@ - Date: Mon, 8 Aug 2022 13:20:25 -0700 Subject: [PATCH 06/25] moving package version change out of a target as per FB --- ...soft.DotNet.ILCompiler.SingleEntry.targets | 26 ++++--------------- .../Microsoft.DotNet.ILCompiler.props | 2 ++ 2 files changed, 7 insertions(+), 21 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index bacb081a0c321..1bf95747a4ff1 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -1,10 +1,5 @@ - - - true - - win @@ -41,22 +36,11 @@ SetupProperties - - - - - - - - - - - + + + @(PackageReference->'%(Version)') + + diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props index c2f2f45bce605..da6b72b12d7ce 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props @@ -11,6 +11,8 @@ Copyright (c) .NET Foundation. All rights reserved. --> + + true $(MSBuildThisFileDirectory)Microsoft.DotNet.ILCompiler.SingleEntry.targets From 3cb58e64a55b2de64cc8b485372b99929d8f95c2 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Tue, 9 Aug 2022 10:46:18 -0700 Subject: [PATCH 07/25] Fix nativeaot test take 2 --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 3 ++- .../BuildIntegration/Microsoft.NETCore.Native.targets | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index 1bf95747a4ff1..1e3d21b1b4629 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -37,6 +37,7 @@ + @(PackageReference->'%(Version)') @@ -54,6 +55,6 @@ - + diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index f39805cc9eddf..4282d9ce0f1fe 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -247,7 +247,7 @@ The .NET Foundation licenses this file to you under the MIT license. - + From 5696f2d1f7ec2f7cdcfda2d212147c2912695f57 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Tue, 9 Aug 2022 17:04:08 -0700 Subject: [PATCH 08/25] disabling a failing test --- src/libraries/tests.proj | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 2d46d69750c30..d0e20435b05d9 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -420,6 +420,8 @@ + + Date: Thu, 4 Aug 2022 16:29:36 -0700 Subject: [PATCH 09/25] Clean up AOT publish process --- .../Microsoft.DotNet.ILCompiler.targets | 43 ++++++++++++------- 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets index d08cc8241da6a..5f19f52f223c5 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets @@ -1,5 +1,12 @@ + + + + true + + + @@ -26,7 +33,6 @@ $(OSHostArch) runtime.$(OSIdentifier)-$(IlcHostArch).Microsoft.DotNet.ILCompiler - true @@ -39,29 +45,34 @@ - - - - - - + + + + + + + + + + + + + + - - + @(ResolvedILCompilerPack->'%(PackageDirectory)') @(ResolvedILCompilerPack->'%(PackageDirectory)') >@(ResolvedILCompilerPack->'%(PackageDirectory)') - - - %(PackageDefinitions.ResolvedPath) - %(PackageDefinitions.ResolvedPath) - - - + From 363fd28acd05c5d81681f55ab4367a4e6bc8a33e Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Fri, 5 Aug 2022 05:46:39 -0700 Subject: [PATCH 10/25] Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets Co-authored-by: Sven Boemer --- .../BuildIntegration/Microsoft.DotNet.ILCompiler.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets index 5f19f52f223c5..7d501e1ae8451 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets @@ -49,7 +49,7 @@ - + From 48b0f744f62c11eaadf15ea6b7b535e29063bcec Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Fri, 5 Aug 2022 05:46:51 -0700 Subject: [PATCH 11/25] Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets Co-authored-by: Sven Boemer --- .../BuildIntegration/Microsoft.DotNet.ILCompiler.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets index 7d501e1ae8451..0d7572fd2bb2d 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.targets @@ -56,7 +56,7 @@ From c1fb84ebbed836e5fcf0feb6e06be234b9d6e7c1 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Sun, 7 Aug 2022 10:41:12 -0700 Subject: [PATCH 12/25] FB and working around running native aot tests --- eng/testing/tests.singlefile.targets | 2 +- .../BuildFrameworkNativeObjects.proj | 2 +- ...oft.DotNet.ILCompiler.SingleEntry.targets} | 27 +++++++++---------- .../Microsoft.DotNet.ILCompiler.props | 3 +-- 4 files changed, 15 insertions(+), 19 deletions(-) rename src/coreclr/nativeaot/BuildIntegration/{Microsoft.DotNet.ILCompiler.targets => Microsoft.DotNet.ILCompiler.SingleEntry.targets} (80%) diff --git a/eng/testing/tests.singlefile.targets b/eng/testing/tests.singlefile.targets index 1cfa4ba1cdeca..e4a246d6ef1c0 100644 --- a/eng/testing/tests.singlefile.targets +++ b/eng/testing/tests.singlefile.targets @@ -34,7 +34,7 @@ true - + diff --git a/src/coreclr/nativeaot/BuildIntegration/BuildFrameworkNativeObjects.proj b/src/coreclr/nativeaot/BuildIntegration/BuildFrameworkNativeObjects.proj index 6469964c0170a..d3ef3ec15cdbb 100644 --- a/src/coreclr/nativeaot/BuildIntegration/BuildFrameworkNativeObjects.proj +++ b/src/coreclr/nativeaot/BuildIntegration/BuildFrameworkNativeObjects.proj @@ -10,7 +10,7 @@ true - + - true - - win osx @@ -33,36 +30,36 @@ $(OSHostArch) runtime.$(OSIdentifier)-$(IlcHostArch).Microsoft.DotNet.ILCompiler - + + true - RunResolvePackageDependencies ImportRuntimeIlcPackageTarget SetupProperties - - - + + - + + TargetFramework="@(OldKnownILCompilerPack ->'%(TargetFramework)')" + ILCompilerPackNamePattern="@(OldKnownILCompilerPack ->'%(ILCompilerPackNamePattern)')" + ILCompilerPackVersion="@(ILCompilerRefernece->'%(Version)')" + ILCompilerRuntimeIdentifiers="@(OldKnownILCompilerPack ->'%(ILCompilerRuntimeIdentifiers)')" + Condition="@(ILCompilerReference->'%(Version)')!=''"/> - + @@ -73,6 +70,6 @@ - + diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props index e883245ee0f7c..c2f2f45bce605 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props @@ -10,10 +10,9 @@ Copyright (c) .NET Foundation. All rights reserved. *********************************************************************************************** --> - - $(MSBuildThisFileDirectory)Microsoft.DotNet.ILCompiler.targets + $(MSBuildThisFileDirectory)Microsoft.DotNet.ILCompiler.SingleEntry.targets From eb13dc8f133b9b4fe6a47a4958b45b58b98cfb5f Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Mon, 8 Aug 2022 03:58:53 -0700 Subject: [PATCH 13/25] update crossgen2 reference --- src/coreclr/tools/aot/crossgen2/crossgen2.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/tools/aot/crossgen2/crossgen2.csproj b/src/coreclr/tools/aot/crossgen2/crossgen2.csproj index 42f192a3f123f..8696352abc03e 100644 --- a/src/coreclr/tools/aot/crossgen2/crossgen2.csproj +++ b/src/coreclr/tools/aot/crossgen2/crossgen2.csproj @@ -42,7 +42,7 @@ - Date: Mon, 8 Aug 2022 13:20:25 -0700 Subject: [PATCH 14/25] moving package version change out of a target as per FB --- ...soft.DotNet.ILCompiler.SingleEntry.targets | 26 ++++--------------- .../Microsoft.DotNet.ILCompiler.props | 2 ++ 2 files changed, 7 insertions(+), 21 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index bacb081a0c321..1bf95747a4ff1 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -1,10 +1,5 @@ - - - true - - win @@ -41,22 +36,11 @@ SetupProperties - - - - - - - - - - - + + + @(PackageReference->'%(Version)') + + diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props index c2f2f45bce605..da6b72b12d7ce 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.props @@ -11,6 +11,8 @@ Copyright (c) .NET Foundation. All rights reserved. --> + + true $(MSBuildThisFileDirectory)Microsoft.DotNet.ILCompiler.SingleEntry.targets From 2a07fcca1a5e2e177a2f2a4781c81f0c5d92ce04 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Tue, 9 Aug 2022 10:46:18 -0700 Subject: [PATCH 15/25] Fix nativeaot test take 2 --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 3 ++- .../BuildIntegration/Microsoft.NETCore.Native.targets | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index 1bf95747a4ff1..1e3d21b1b4629 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -37,6 +37,7 @@ + @(PackageReference->'%(Version)') @@ -54,6 +55,6 @@ - + diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index 5ded3960f2795..f72d8df511d0c 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -245,7 +245,7 @@ The .NET Foundation licenses this file to you under the MIT license. - + From 8038c58321a3015a0cd47f6b9e2e1f64de4403f3 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Tue, 9 Aug 2022 17:04:08 -0700 Subject: [PATCH 16/25] disabling a failing test --- src/libraries/tests.proj | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index d1a1ffe538402..4c46de7b03068 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -419,6 +419,8 @@ + + Date: Wed, 10 Aug 2022 12:00:14 -0700 Subject: [PATCH 17/25] Remove TrimMode workaround --- .../nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index f72d8df511d0c..5ded3960f2795 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -245,7 +245,7 @@ The .NET Foundation licenses this file to you under the MIT license. - + From 590741636de5d55f7b65a472daa09f01335fa3a8 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Thu, 11 Aug 2022 10:57:21 -0700 Subject: [PATCH 18/25] work around a test issue --- src/libraries/tests.proj | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 4c46de7b03068..e32f24d1c97f8 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -421,6 +421,7 @@ + Date: Thu, 11 Aug 2022 14:47:31 -0700 Subject: [PATCH 19/25] Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets Co-authored-by: Sven Boemer --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index 1e3d21b1b4629..e9381c6f13da2 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -37,7 +37,7 @@ - + @(PackageReference->'%(Version)') From 80cedc4bc18b85ee70d48e4df1919e3b70611f1d Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Thu, 11 Aug 2022 14:47:40 -0700 Subject: [PATCH 20/25] Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets Co-authored-by: Sven Boemer --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index e9381c6f13da2..933f60491db76 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -55,6 +55,6 @@ - + From 80faf9474e1fca5fa8d18eff36671e7c2d1bb014 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Fri, 12 Aug 2022 11:36:39 -0700 Subject: [PATCH 21/25] update the version check for package --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 6 ++++-- src/libraries/tests.proj | 3 +++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index 933f60491db76..cd51cc9511f99 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -38,8 +38,10 @@ - - @(PackageReference->'%(Version)') + <_PackageReferenceExceptILCompiler Include="@(PackageReference)" Exclude="Microsoft.DotNet.ILCompiler" /> + <_ILCompilerPackageReference Include="@(PackageReference)" Exclude="@(_PackageReferenceExceptILCompiler)" /> + + @(_ILCompilerPackageReference->'%(Version)') diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index e32f24d1c97f8..886a771ed483a 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -422,6 +422,8 @@ + + + From 141c61fdb14f88975a45f0b290be6fb35b58c6fc Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Sun, 14 Aug 2022 07:00:38 -0700 Subject: [PATCH 22/25] Cross target support, requires changes from SDK --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 6 +++--- .../BuildIntegration/Microsoft.NETCore.Native.targets | 2 +- src/libraries/tests.proj | 7 +------ 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index cd51cc9511f99..f67b7bb7292cc 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -50,9 +50,9 @@ - @(ResolvedILCompilerPack->'%(PackageDirectory)') - @(ResolvedILCompilerPack->'%(PackageDirectory)') - >@(ResolvedILCompilerPack->'%(PackageDirectory)') + @(ResolvedILCompilerPack->'%(PackageDirectory)') + @(ResolvedILCompilerPack2->'%(PackageDirectory)') + @(ResolvedILCompilerPack->'%(PackageDirectory)') diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index f72d8df511d0c..5ded3960f2795 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -245,7 +245,7 @@ The .NET Foundation licenses this file to you under the MIT license. - + diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 886a771ed483a..8a6705fab817b 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -419,12 +419,7 @@ - - - - - - + From de74e2bab3cd7ff528172e500e7422513bce8ae9 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Mon, 15 Aug 2022 07:50:44 -0700 Subject: [PATCH 23/25] Change ResolvedTargetILCompilerPack to match SDK changes --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index f67b7bb7292cc..b7dd29c14191d 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -51,8 +51,8 @@ @(ResolvedILCompilerPack->'%(PackageDirectory)') - @(ResolvedILCompilerPack2->'%(PackageDirectory)') - @(ResolvedILCompilerPack->'%(PackageDirectory)') + @(ResolvedTargetILCompilerPack->'%(PackageDirectory)') + @(ResolvedILCompilerPack->'%(PackageDirectory)') From 62ce9bde1d3b65eda7c35bf68118218c7b6fe863 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Mon, 15 Aug 2022 11:20:45 -0700 Subject: [PATCH 24/25] FB --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index b7dd29c14191d..0018c70f98779 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -52,7 +52,7 @@ @(ResolvedILCompilerPack->'%(PackageDirectory)') @(ResolvedTargetILCompilerPack->'%(PackageDirectory)') - @(ResolvedILCompilerPack->'%(PackageDirectory)') + @(ResolvedILCompilerPack->'%(PackageDirectory)') From ff574f8a03dbf7ecbe30cdbad782422a88ba0e98 Mon Sep 17 00:00:00 2001 From: Lakshan Fernando Date: Mon, 15 Aug 2022 12:08:07 -0700 Subject: [PATCH 25/25] Trigger Build to fix interop break