Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix diagnosticport test failure in ilasm/ildasm round-trip testing #80766

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix diagnosticport test failure in ilasm/ildasm round-trip testing #80766

merged 1 commit into from
Jan 18, 2023

Conversation

elinor-fung
Copy link
Member

Fixes #80680

@ghost ghost assigned elinor-fung Jan 18, 2023
@ghost
Copy link

ghost commented Jan 18, 2023

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #80680

Author: elinor-fung
Assignees: -
Labels:

area-System.Diagnostics.Tracing
Milestone: -

@elinor-fung elinor-fung added test-bug Problem in test source code (most likely) area-Diagnostics-coreclr and removed area-System.Diagnostics.Tracing labels Jan 18, 2023
@ghost
Copy link

ghost commented Jan 18, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #80680

Author: elinor-fung
Assignees: elinor-fung
Labels:

test-bug, area-Diagnostics-coreclr
Milestone: -

@elinor-fung
Copy link
Member Author

/azp run runtime-coreclr ilasm

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@elinor-fung elinor-fung mentioned this pull request Jan 18, 2023
Closed
BruceForstall
BruceForstall approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ilasm round-trip test passes.

@BruceForstall
Copy link
Member

I manually triggered ilasm:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=140755&view=results

Not sure why comment trigger doesn't work.

@build-analysis build-analysis bot mentioned this pull request Jan 18, 2023
Closed
davmason
davmason approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@davmason davmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@runfoapp runfoapp bot mentioned this pull request Jan 18, 2023
Closed
@elinor-fung
Copy link
Member Author

Failures are known:

@elinor-fung elinor-fung merged commit 0e77e6b into dotnet:main Jan 18, 2023
@elinor-fung elinor-fung deleted the fix80680 branch January 18, 2023 15:43
@ghost ghost locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davmason davmason davmason approved these changes

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees

@elinor-fung elinor-fung

Labels
area-Diagnostics-coreclr test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure tracing\\eventpipe\\diagnosticport\\diagnosticport\\diagnosticport.cmd
3 participants
@elinor-fung @BruceForstall @davmason