Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MemoryExtensions.TryWriteUtf8 #83761

Closed
wants to merge 1 commit into from

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Mar 22, 2023

Initial implementation of MemoryExtensions.TryWriteUtf8. The performance of this won't be great at present, but will improve as our cores types add implementation of IUtf8SpanFormattable. For tests, I copy/pasted the tests we had for TryWrite and searched/replaced to make them work for TryWriteUtf8.

Fixes #79376
Contributes to #81500

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Mar 22, 2023

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Initial implementation of MemoryExtensions.TryWriteUtf8. The performance of this won't be great at present, but will improve as our cores types add implementation of IUtf8SpanFormattable. For tests, I copy/pasted the tests we had for TryWrite and searched/replaced to make them work for TryWriteUtf8.

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Memory, new-api-needs-documentation

Milestone: -

Initial implementation of MemoryExtensions.TryWriteUtf8. The performance of this won't be great at present, but will improve as our cores types add implementation of IUtf8SpanFormattable. For tests, I copy/pasted the tests we had for TryWrite and searched/replaced to make them work for TryWriteUtf8.
@stephentoub
Copy link
Member Author

We decided to move the support to a different type. I'll close this and open a new PR with the revision soon.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2023
@stephentoub stephentoub deleted the memextutf8trywrite branch June 29, 2023 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: MemoryExtensions.TryWrite for UTF8
1 participant