Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Update dependencies from dotnet/xharness #83829

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/xharness

  • Subscription: e0fabb4f-43ca-46cf-d489-08db2b08e5ae
  • Build: 20230313.1
  • Date Produced: March 13, 2023 6:05:54 PM UTC
  • Commit: 0ff1a841e0a5949428c3868258b14ddcfa0da903
  • Branch: refs/heads/main

…30313.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.21404.1 -> To Version 1.0.0-prerelease.23163.1
@carlossanlop
Copy link
Member

This PR hit a lot of failures. The known issues were all linked above by the bot.

I did find a new issue. @lewing @steveisok @radical is this issue related to the current PR? If not, let me know and I can open an issue for it.

Starting ChromeDriver 84.0.4147.0 (ff714bcb10c3356b1b1b2819148507a34fa4b1f8-refs/heads/master@{#768968}) on port 37171
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
[01:48:39] crit: System.Exception: Can't find type named GenericHandler in /datadisks/disk1/work/BE8E0A9C/p/xharness/RemoteLoopMiddleware/RemoteLoopServer.dll
                    at Microsoft.DotNet.XHarness.CLI.CommandArguments.TypeFromAssemblyArgument`1.GetLoadedTypes()+MoveNext() in /_/src/Microsoft.DotNet.XHarness.CLI/CommandArguments/Arguments/TypeFromAssemblyArgument.cs:line 31
                    at Microsoft.DotNet.XHarness.CLI.Commands.WebServer.TestWebServerOptions.FromArguments(IWebServerArguments arguments) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WebServer.cs:line 215
                    at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmBrowserTestRunner.RunTestsWithWebDriver(DriverService driverService, IWebDriver driver) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmBrowserTestRunner.cs:line 63
                    at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmTestBrowserCommand.InvokeInternal(ILogger logger) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs:line 77
                    at Microsoft.DotNet.XHarness.CLI.Commands.XHarnessCommand`1.Invoke(IEnumerable`1 arguments) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/XHarnessCommand.cs:line 145
XHarness exit code: 71 (GENERAL_FAILURE)

@lewing
Copy link
Member

lewing commented Mar 29, 2023

That is a new one to me but this is a huge delta from the previous xharness in 6.0 so I'm not really surprised there are issues?
Commits 241
Files changed 510

@steveisok
Copy link
Member

@premun @akoeplinger are there extras in runtime we need to accompany this?

@hoyosjs hoyosjs added the Servicing-approved Approved for servicing release label Mar 30, 2023
@hoyosjs hoyosjs changed the base branch from release/6.0 to release/6.0-staging March 30, 2023 01:10
@carlossanlop carlossanlop changed the base branch from release/6.0-staging to release/6.0 March 30, 2023 01:32
@carlossanlop
Copy link
Member

carlossanlop commented Mar 30, 2023

Sorry for the noise. @hoyosjs and I saw a weird behavior in the new label check and were investigating by changing the branch.

@premun
Copy link
Member

premun commented Mar 30, 2023

I don't have much knowledge about the WASM parts of XHarness. I don't think there's anything else needed but also no idea what is this RemoteLoopServer. I believe it's a dynamically loaded DLL that we load via ASP.NET as a middleware or something. So I guess there's a mismatch in what we're loading?

@premun
Copy link
Member

premun commented Mar 30, 2023

Afaik, we don't really need this update for anything worthwhile

@carlossanlop
Copy link
Member

Afaik, we don't really need this update for anything worthwhile

@premun Should I turn off the darc subscription and close the PR? Same question for the 7.0 one which also has failures: #83828

@premun
Copy link
Member

premun commented Mar 31, 2023

Yeah, that's probably a good idea

@akoeplinger
Copy link
Member

The only thing would be the mlaunch bump in xharness since I believe that was needed for recent Xcode versions.

RemoteLoopServer is coming from the runtime repo, see https://github.com/dotnet/runtime/tree/main/src/libraries/Common/tests/System/Net/Prerequisites/RemoteLoopServer.

We might want to branch xharness as well so we could just cherry-pick fixes like the mlaunch bump.

@premun
Copy link
Member

premun commented Mar 31, 2023

Yeah, branching XHarness is probably the right thing to do. I created dotnet/xharness#1010 and can take care of this

@carlossanlop
Copy link
Member

Afaik, we don't really need this update for anything worthwhile

@premun Should I turn off the darc subscription and close the PR? Same question for the 7.0 one which also has failures: #83828

Yeah, that's probably a good idea

Per the conversation above, I have disabled runtime's darc subscriptions to xharness in both 6.0 and 7.0, so we can now close the PR.

@dotnet-maestro dotnet-maestro bot deleted the darc-release/6.0-fef94429-e3d3-4880-a2be-febfd2e3e874 branch April 10, 2023 18:44
@ghost ghost locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants