Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper parsing for primitives in config binding gen #84154

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Implement proper parsing for primitives in config binding gen #84154

merged 2 commits into from
Apr 12, 2023

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Mar 31, 2023

Fixes #83533.

@layomia layomia added this to the 8.0.0 milestone Mar 31, 2023
@layomia layomia self-assigned this Mar 31, 2023
@ghost
Copy link

ghost commented Mar 31, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #83533.

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration
Milestone: 8.0.0

@build-analysis build-analysis bot mentioned this pull request Mar 31, 2023
Closed
@layomia layomia force-pushed the binder-gen-proper-primitive-parsing branch from f553401 to 8326b94 Compare April 1, 2023 17:22
@build-analysis build-analysis bot mentioned this pull request Apr 1, 2023
Closed
@layomia layomia force-pushed the binder-gen-proper-primitive-parsing branch from 8326b94 to 2e52600 Compare April 4, 2023 23:39
@layomia layomia force-pushed the binder-gen-proper-primitive-parsing branch from 2e52600 to 0f222cd Compare April 4, 2023 23:45
@layomia layomia marked this pull request as ready for review April 4, 2023 23:46
@build-analysis build-analysis bot mentioned this pull request Apr 5, 2023
Closed
tarekgh
tarekgh approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments, LGTM otherwise.

@layomia layomia force-pushed the binder-gen-proper-primitive-parsing branch 6 times, most recently from 15facda to 7d2c810 Compare April 12, 2023 03:47
@layomia layomia force-pushed the binder-gen-proper-primitive-parsing branch from 7d2c810 to 3d50b85 Compare April 12, 2023 06:19
@layomia layomia merged commit e4082bf into dotnet:main Apr 12, 2023
This was referenced Apr 12, 2023
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
@layomia layomia deleted the binder-gen-proper-primitive-parsing branch May 22, 2023 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@eerhardt eerhardt eerhardt left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@krwq krwq Awaiting requested review from krwq

Assignees

@layomia layomia

Labels
area-Extensions-Configuration
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Implement proper parsing of primitives in config binder generator
4 participants
@layomia @eiriktsarpalis @eerhardt @tarekgh