Use unique IL assembly names instead of automatic renaming #85185
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata Issue DetailsThe main motivation for this is that I got stuck trying to write documentation for test merging and test suffixes. We have _il_d for IL and both _d and _cs_d for C# (and similar for _r and others - I'll use _d to denote all such tests here). Only the IL files needed to be separated into different merged groups, yet we split the C# as well. This change renames the _il_d to just _d (unless there is already an existing _d, likely for a C# version of the test). It then replaces This lets me remove the 4 Regression merged groups with ~10 tests each in them. I rebalanced the merged groups where the number of _d tests were larger except HardwareIntrinsics (a unique directory) and Methodical (most of the tests are _d).
|
markples
added
test-enhancement
|
PTAL @trylek @jkoritzinsky The github view on this is pretty bad between the large number of files and missing the renames. The commits are logically separated:
|
|
A local pri 1 build/run showed that I didn't lose swaths of tests. I'll run outerloop, extraplatforms, and gcstress - the last after my jit64 changes are merged. |
|
/azp run runtime-coreclr outerloop, runtime-extra-platforms |
|
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Thanks Mark, this indeed looks much cleaner than the hacky assembly renames in the scripts. It almost makes me wonder whether there might be a way to define the ASSEMBLY_NAME macro directly in the MSBuild script so that we don't need the auxiliary one-line IL files but I guess I'm probably asking too much, this is a nice improvement by itself already.
|
/azp run runtime-coreclr outerloop, runtime-extra-platforms |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms, gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms, gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
(just retesting because old runs were old and noisy, no new changes requiring re-review) |
|
/azp run runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
MemorySsa is failing elsewhere |
ghost
locked as resolved and limited conversation to collaborators
The main motivation for this is that I got stuck trying to write documentation for test merging and test suffixes. We have _il_d for IL and both _d and _cs_d for C# (and similar for _r and others - I'll use _d to denote all such tests here). Only the IL files needed to be separated into different merged groups, yet we split the C# as well.
This change renames the _il_d to just _d (unless there is already an existing _d, likely for a C# version of the test). It then replaces
.assembly <name>with.assembly ASSEMBLY_NAMEand adds per-configuration "prefix" IL source files with#define ASSEMBLY_NAME <name>_d. Then the rules are simple - tests have unique assembly names and no build-time renaming is required.This lets me remove the 4 Regression merged groups with ~10 tests each in them. I rebalanced the merged groups where the number of _d tests were larger except HardwareIntrinsics (a unique directory) and Methodical (most of the tests are _d).