Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert JIT/Generics to a merged test group #85849

Merged
merged 10 commits into from
May 12, 2023
Merged

Convert JIT/Generics to a merged test group #85849

merged 10 commits into from
May 12, 2023

Conversation

markples
Copy link
Member

@markples markples commented May 5, 2023 •
edited
Loading

See https://github.com/markples/utils/tree/for-PR-dotnet-runtime-85847-others for ILTransform tool. As usual, I recommend viewing the commit list since it partitions the changes in a more readable way and paying more attention to manual changes.

  • outerloop, extra-platforms, gcstress

@markples markples added the test-enhancement Improvements of test source code label May 5, 2023
@markples markples self-assigned this May 5, 2023
@ghost
Copy link

ghost commented May 5, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

See https://github.com/markples/utils/tree/for-PR-dotnet-runtime-85847-others for ILTransform tool

Author: markples
Assignees: markples
Labels:

area-System.Reflection.Metadata, test-enhancement
Milestone: -

@markples markples added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-System.Reflection.Metadata labels May 5, 2023
@ghost
Copy link

ghost commented May 5, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

See https://github.com/markples/utils/tree/for-PR-dotnet-runtime-85847-others for ILTransform tool. As usual, I recommend viewing the commit list since it partitions the changes in a more readable way.

Author: markples
Assignees: markples
Labels:

test-enhancement, area-CodeGen-coreclr
Milestone: -

@markples
Copy link
Member Author

markples commented May 6, 2023

/azp run runtime-coreclr outerloop, runtime-extra-platforms, runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@markples markples mentioned this pull request May 6, 2023
Open
33 tasks
This was referenced May 6, 2023
Open
Closed
Closed
Closed
@markples markples marked this pull request as ready for review May 12, 2023 11:37
@markples
Copy link
Member Author

This is ready @trylek @dotnet/jit-contrib

trylek
trylek approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks Mark!

@markples markples merged commit c2750cb into dotnet:main May 12, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

Assignees

@markples markples

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI test-enhancement Improvements of test source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markples @trylek