[main] Update dependencies from 7 repositories #85913

…0507.3 Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json From Version 8.0.0-preview.5.23251.1 -> To Version 8.0.0-preview.5.23257.3

… 20230508.2 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23228.1 -> To Version 14.0.0-alpha.1.23258.2

…30509.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23253.1 -> To Version 8.0.0-prerelease.23259.1

…08.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.5.23252.1 -> To Version 8.0.0-preview.5.23258.1

…ild 20230508.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23252.1 -> To Version 8.0.0-alpha.0.23258.1

…09.1 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23252.1 -> To Version 0.11.4-alpha.23259.1

…ild 20230509.2 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23252.1 -> To Version 8.0.0-alpha.0.23259.2

…ild 20230515.2 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23252.1 -> To Version 8.0.0-alpha.0.23265.2

…15.2 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23252.1 -> To Version 0.11.4-alpha.23265.2

akoeplinger · 2023-05-17T13:02:32Z

The installer tests fail with this error now:

System.TypeLoadException : Could not load type 'System.Buffers.SearchValues`1' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.

Stack trace
   at System.Text.Json.Utf8JsonReader.ConsumeString()
   at System.Text.Json.Utf8JsonReader.ConsumePropertyName()
   at System.Text.Json.Utf8JsonReader.ReadSingleSegment()
   at System.Text.Json.Utf8JsonReader.Read()
   at System.Text.Json.JsonDocument.TryParseValue(Utf8JsonReader& reader, JsonDocument& document, Boolean shouldThrow, Boolean useArrayPools)
   at Microsoft.DotNet.CoreSetup.Test.RuntimeConfig.FromFile(String path) in /_/src/installer/tests/TestUtils/RuntimeConfig.cs:line 126
   at Microsoft.DotNet.CoreSetup.Test.HostActivation.FrameworkResolution.DotNetCliExtensions.DotNetFramework.RuntimeConfig(Action`1 runtimeConfigCustomizer) in /_/src/installer/tests/HostActivation.Tests/FrameworkResolution/DotNetCliExtensions.cs:line 80
   at Microsoft.DotNet.CoreSetup.Test.HostActivation.FrameworkResolution.RollForwardOnNoCandidateFxMultipleFrameworks.<>c__DisplayClass17_0.<ReconcileFrameworkReferences_InnerToInnerFrameworkReference_ToLower>b__1(DotNetCliCustomizer dotnetCustomizer) in /_/src/installer/tests/HostActivation.Tests/FrameworkResolution/RollForwardOnNoCandidateFxMultipleFrameworks.cs:line 354
   at Microsoft.DotNet.CoreSetup.Test.HostActivation.FrameworkResolution.FrameworkResolutionBase.RunTest(DotNetCli dotnet, TestApp app, TestSettings settings, Action`1 resultAction, Nullable`1 multiLevelLookup) in /_/src/installer/tests/HostActivation.Tests/FrameworkResolution/FrameworkResolutionBase.cs:line 31
   at Microsoft.DotNet.CoreSetup.Test.HostActivation.FrameworkResolution.RollForwardOnNoCandidateFxMultipleFrameworks.RunTest(Func`2 runtimeConfig, Action`1 customizeDotNet) in /_/src/installer/tests/HostActivation.Tests/FrameworkResolution/RollForwardOnNoCandidateFxMultipleFrameworks.cs:line 488
   at Microsoft.DotNet.CoreSetup.Test.HostActivation.FrameworkResolution.RollForwardOnNoCandidateFxMultipleFrameworks.ReconcileFrameworkReferences_InnerToInnerFrameworkReference_ToLower(String versionReference, Nullable`1 rollForwardOnNoCandidateFx, Nullable`1 applyPatches, String resolvedFramework) in /_/src/installer/tests/HostActivation.Tests/FrameworkResolution/RollForwardOnNoCandidateFxMultipleFrameworks.cs:line 349
   at InvokeStub_RollForwardOnNoCandidateFxMultipleFrameworks.ReconcileFrameworkReferences_InnerToInnerFrameworkReference_ToLower(Object, Object, IntPtr*)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

akoeplinger · 2023-05-17T13:07:23Z

Ah we hit a similar issue on the sdk dependency update: dotnet/sdk#32250 (comment)

I'm not sure why we hit this here though, it looks like the installer tests don't run with the just built dotnet runtime?

vitek-karas · 2023-05-17T13:51:03Z

@elinor-fung for ideas.

It's possible that we run the test with the SDK (as the tests themselves are not running the tested bits in-proc anyway), but I would expect that to be internally consistent.

elinor-fung · 2023-05-17T14:58:24Z

The installer tests themselves run with the SDK, not the live-built runtime. The tests launch separate processes - those processes are the live-built hosts using the live-built runtime.

elinor-fung · 2023-05-18T10:31:56Z

System.Text.Json is being referenced here (which the tests use):

runtime/src/installer/managed/Microsoft.NET.HostModel/Microsoft.NET.HostModel.csproj

Line 24 in 4db4bb5

    
           <PackageReference Include="System.Text.Json" Version="$(SystemTextJsonVersion)" />

This PR updates that version to one that uses System.Buffers.SearchValues.

I'm not sure what to do here.

The basic situation is an app pulling in a newer System.Text.Json package and then running on a version of the runtime without the breaking change. For example:

Configure an application to use the latest 8.0 System.Text.Json:

<PackageReference Include="System.Text.Json" Version="8.0.0-*" />

Add the dotnet8 nuget feed to get at the packages with the breaking change (presumably not needed once Preview 5 ships):
```
<add key="dotnet8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json" />
```

Read/parse some json:

var reader = new Utf8JsonReader("{\"name\":\"value\"}"u8);
JsonObject root = (JsonObject)JsonNode.Parse(ref reader);

Run on a version of .NET that doesn't have the breaking change (like .NET 8 preview 4)

Unhandled exception. System.TypeLoadException: Could not load type 'System.Buffers.SearchValues`1' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
   at System.Text.Json.Utf8JsonReader.ConsumeString()
   at System.Text.Json.Utf8JsonReader.ConsumePropertyName()
   at System.Text.Json.Utf8JsonReader.ReadSingleSegment()
   at System.Text.Json.Utf8JsonReader.Read()
   at System.Text.Json.Utf8JsonReader.TrySkip()
   at System.Text.Json.JsonDocument.TryParseValue(Utf8JsonReader& reader, JsonDocument& document, Boolean shouldThrow, Boolean useArrayPools)
   at System.Text.Json.JsonElement.ParseValue(Utf8JsonReader& reader)
   at System.Text.Json.Nodes.JsonNode.Parse(Utf8JsonReader& reader, Nullable`1 nodeOptions)
   at Program.Main(String[] args) in C:\repos\helloworld\Program.cs:line 19

vitek-karas · 2023-05-18T12:22:05Z

We could change the package reference to point to the "old" version of S.T.Json, then it should work with the SDK in the repo. And then when we update the SDK - this will break again and we will revert it back to the live-built S.T.Json.

elinor-fung · 2023-05-18T14:34:23Z

I'm seeing if we can have get that dependency stop propagating to the tests / test utils - hoping to avoid the pin version / break / revert (and any second-level effect of that from SDK consuming Microsoft.NET.HostModel). If not, we can go with pointing at an old version to unblock this flow.

cc @MihaZupan for the OOB package behaviour per #85913 (comment). Not sure if that is a scenario we think users will hit, but I didn't see anything in the breaking change issue that mentions it or indicates how to resolve it.

stephentoub · 2023-05-18T14:37:42Z

Not sure if that is a scenario we think users will hit, but I didn't see anything in the breaking change issue that mentions it or indicates how to resolve it.

This is all within .NET 8, taking advantage of new APIs added in .NET 8 from an asset targeting .NET 8. We don't create breaking change issues for such things. It's a key tenet of adding new APIs that we use them wherever it's relevant to do so. And there's an expectation that if someone is trying out .NET 8, they're doing so using consistent preview versions of the libraries and runtime.

This reverts commit b8ed3a2.

This reverts commit b8a5444.

lewing

The failures appear to be unrelated, thank you @elinor-fung

…30509.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23253.1 -> To Version 8.0.0-prerelease.23259.1

… 20230519.1 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23228.1 -> To Version 14.0.0-alpha.1.23269.1

akoeplinger · 2023-05-22T07:40:01Z

The iOS failure is unrelated, merging.

dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label May 8, 2023

lewing added the area-Infrastructure-installer label May 8, 2023

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/runtime~~ [main] Update dependencies from dotnet/runtime dotnet/llvm-project May 9, 2023

lewing approved these changes May 9, 2023

View reviewed changes

build-analysis bot mentioned this pull request May 9, 2023

Could not find chrome snapshot folder for Linux_x64 #85949

Closed

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/runtime dotnet/llvm-project~~ [main] Update dependencies from dotnet/runtime dotnet/llvm-project dotnet/xharness May 9, 2023

Update dependencies from https://github.com/dotnet/emsdk build 202305…

07723e8

…08.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.5.23252.1 -> To Version 8.0.0-preview.5.23258.1

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/runtime dotnet/llvm-project dotnet/xharness~~ [main] Update dependencies from dotnet/runtime dotnet/llvm-project dotnet/xharness dotnet/emsdk May 9, 2023

dotnet-maestro bot added 2 commits May 9, 2023 13:25

Update dependencies from https://github.com/dotnet/hotreload-utils bu…

d845673

…ild 20230508.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23252.1 -> To Version 8.0.0-alpha.0.23258.1

Update dependencies from https://github.com/dotnet/cecil build 202305…

58c755d

…09.1 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23252.1 -> To Version 0.11.4-alpha.23259.1

dotnet-maestro bot changed the title ~~[main] Update dependencies from dotnet/runtime dotnet/llvm-project dotnet/xharness dotnet/emsdk~~ [main] Update dependencies from dotnet/runtime dotnet/llvm-project dotnet/xharness dotnet/emsdk dotnet/hotreload-utils dotnet/cecil May 9, 2023

Update dependencies from https://github.com/dotnet/hotreload-utils bu…

1903000

…ild 20230509.2 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23252.1 -> To Version 8.0.0-alpha.0.23259.2

lewing closed this May 11, 2023

lewing reopened this May 11, 2023

dotnet-maestro bot added 2 commits May 16, 2023 13:32

Update dependencies from https://github.com/dotnet/hotreload-utils bu…

7108c5b

…ild 20230515.2 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23252.1 -> To Version 8.0.0-alpha.0.23265.2

Update dependencies from https://github.com/dotnet/cecil build 202305…

39f9d0f

…15.2 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23252.1 -> To Version 0.11.4-alpha.23265.2

build-analysis bot mentioned this pull request May 16, 2023

[6.0] HostActivation Tests windows x86 build failure #81851

Open

elinor-fung added 5 commits May 18, 2023 09:08

Fix host tests - don't propagate package reference

b8ed3a2

Merge branch 'main' into darc-main-66bef9d5-62ab-4b75-82e0-13678cd02e4b

9a6b9bf

Revert "Fix host tests - don't propagate package reference"

53dd727

This reverts commit b8ed3a2.

Use old package version

b8a5444

Revert "Use old package version"

732b162

This reverts commit b8a5444.

This was referenced May 18, 2023

Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637

Open

Several XML tests are sporadically failing in CI due to OOMs #82894

Closed

Explicitly remove System.Text.Json pacakge item from tests

8bfabe7

build-analysis bot mentioned this pull request May 19, 2023

Tracking issue for CI build timeouts #76454

Closed

lewing approved these changes May 19, 2023

View reviewed changes

vitek-karas mentioned this pull request May 19, 2023

[main] Installer HostActivation/HostModel.ComHost Tests failing in coreclr x86/x64 windows/osx #86520

Closed

build-analysis bot mentioned this pull request May 20, 2023

Build ios-arm64 Release AllSubsets_Mono failures dotnet/arcade#13625

Closed

3 tasks

akoeplinger merged commit 9e49620 into main May 22, 2023

akoeplinger deleted the darc-main-66bef9d5-62ab-4b75-82e0-13678cd02e4b branch May 22, 2023 07:40

baronfel mentioned this pull request May 30, 2023

Containers: fix handling of ContainerBaseImage without a registry. dotnet/sdk#32876

Merged

ghost locked as resolved and limited conversation to collaborators Jun 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from 7 repositories #85913

[main] Update dependencies from 7 repositories #85913

dotnet-maestro bot commented May 8, 2023 •

edited

Loading

akoeplinger commented May 17, 2023

akoeplinger commented May 17, 2023 •

edited

Loading

vitek-karas commented May 17, 2023

elinor-fung commented May 17, 2023

elinor-fung commented May 18, 2023 •

edited

Loading

vitek-karas commented May 18, 2023

elinor-fung commented May 18, 2023

stephentoub commented May 18, 2023 •

edited

Loading

lewing left a comment •

edited

Loading

akoeplinger commented May 22, 2023

[main] Update dependencies from 7 repositories #85913

[main] Update dependencies from 7 repositories #85913

Conversation

dotnet-maestro bot commented May 8, 2023 • edited Loading

From https://github.com/dotnet/runtime

From https://github.com/dotnet/llvm-project

From https://github.com/dotnet/xharness

From https://github.com/dotnet/emsdk

From https://github.com/dotnet/hotreload-utils

From https://github.com/dotnet/cecil

From https://github.com/dotnet/runtime-assets

akoeplinger commented May 17, 2023

akoeplinger commented May 17, 2023 • edited Loading

vitek-karas commented May 17, 2023

elinor-fung commented May 17, 2023

elinor-fung commented May 18, 2023 • edited Loading

vitek-karas commented May 18, 2023

elinor-fung commented May 18, 2023

stephentoub commented May 18, 2023 • edited Loading

lewing left a comment • edited Loading

Choose a reason for hiding this comment

akoeplinger commented May 22, 2023

dotnet-maestro bot commented May 8, 2023 •

edited

Loading

akoeplinger commented May 17, 2023 •

edited

Loading

elinor-fung commented May 18, 2023 •

edited

Loading

stephentoub commented May 18, 2023 •

edited

Loading

lewing left a comment •

edited

Loading